Skip to content

update firewalle control plane#23

Closed
Abiorh001 wants to merge 1 commit intomainfrom
fix_financial_firewall
Closed

update firewalle control plane#23
Abiorh001 wants to merge 1 commit intomainfrom
fix_financial_firewall

Conversation

@Abiorh001
Copy link
Copy Markdown
Contributor

No description provided.

@Cloriskitty
Copy link
Copy Markdown
Contributor

Hey Abiola — thanks for putting this together. A few things need attention before this can be merged:

1. CI Lint is failing

The Lint check failed in 10 seconds, which means there are obvious lint/format errors. Please run ruff check and ruff format locally and fix all issues before pushing again.

2. PR description is missing

This PR touches 17 files with +399 / -212 lines of changes across the firewall control plane, policy engine, Circle client, and more — but there's no description explaining:

  • What was changed and why
  • How to test it
  • What problem this solves

Please add a proper PR description so reviewers can understand the scope and intent.

3. Title typo

"update firewalle control plane" → should be "firewall" (extra 'e').

4. Explain the changes

From what I can see, the key files modified are:

  • policy.py (+96/-79) — policy engine changes
  • circle_client.py (+92/-58) — Circle integration updates
  • client.py (+61/-13) — client interface changes
  • routes.py (+32/-16) — API route updates
  • onboarding.py (+23/-14) — onboarding flow changes
  • models.py (+19/-0) — new model additions

Please document what each major change does so we can review effectively.


We have branch protection on main now — Lint and Test checks must pass and 1 approving review is required before merging. Let's get this cleaned up!

@Abiorh001 Abiorh001 closed this Mar 30, 2026
@Abiorh001 Abiorh001 deleted the fix_financial_firewall branch March 30, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants