Skip to content

fish-shell 4 : add new recipe#1675

Open
extrowerk wants to merge 3 commits intoomniosorg:masterfrom
extrowerk:fish_shell-4.0.6
Open

fish-shell 4 : add new recipe#1675
extrowerk wants to merge 3 commits intoomniosorg:masterfrom
extrowerk:fish_shell-4.0.6

Conversation

@extrowerk
Copy link
Copy Markdown
Contributor

@extrowerk extrowerk commented Nov 1, 2025

@extrowerk extrowerk changed the title Fish-shell 4.0.6 added Fish-shell 4.x added Nov 4, 2025
hadfl
hadfl reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hadfl hadfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. There are a few nits (see below).

On top, can you please add the package to doc/packages.md as well as doc/baseline

build/fish/build.sh
DESC="friendly interactive shell"

SKIP_SSP_CHECK=1
SKIP_LICENCES=COPYING
Copy link
Copy Markdown
Member

@hadfl hadfl Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the licence is GPLv2 like stated in local.mog can the pattern in doc/licences be adjusted to parse it properly than just "skipping" it?

Copy link
Copy Markdown
Contributor Author

@extrowerk extrowerk Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't fully GPLv2 : https://github.com/fish-shell/fish-shell/blob/master/COPYING
How should I handle this?

@extrowerk
Copy link
Copy Markdown
Contributor Author

extrowerk commented Nov 5, 2025

Thank you for your contribution. There are a few nits (see below).

On top, can you please add the package to doc/packages.md as well as doc/baseline

Done

@extrowerk
Copy link
Copy Markdown
Contributor Author

extrowerk commented Nov 13, 2025

Recipe updated to 4.2.0 using the patches from the OpenIndiana repo: https://github.com/OpenIndiana/oi-userland/tree/oi/hipster/components/shell/fish

@extrowerk extrowerk requested a review from hadfl November 13, 2025 07:17
@extrowerk extrowerk changed the title Fish-shell 4.x added fish-shell 4 : add new recipe Nov 14, 2025
@extrowerk
Copy link
Copy Markdown
Contributor Author

extrowerk commented Dec 8, 2025 •
edited
Loading

It is OK to merge.

@extrowerk
Copy link
Copy Markdown
Contributor Author

extrowerk commented Dec 19, 2025

I made a private repo and using now fish via that since the last couple of days. It seems to be working fine.

@extrowerk extrowerk force-pushed the fish_shell-4.0.6 branch 2 times, most recently from dce9123 to 23decaf Compare January 1, 2026 13:04
@extrowerk
Copy link
Copy Markdown
Contributor Author

extrowerk commented Jan 1, 2026 •
edited
Loading

Updated to the latest 4.3.2 using https://github.com/OpenIndiana/oi-userland/tree/oi/hipster/components/shell/fish

user@omnios ~> fish --version
fish, version 4.3.2
user@omnios ~> uname -a
SunOS omnios 5.11 omnios-r151056-9fd2b931e3 i86pc i386 i86pc

@extrowerk
Copy link
Copy Markdown
Contributor Author

extrowerk commented Jan 7, 2026

Bumped to 4.3.3, patches synced.

@extrowerk
Copy link
Copy Markdown
Contributor Author

extrowerk commented Feb 5, 2026

Updated to 4.4.0

@extrowerk extrowerk mentioned this pull request Mar 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@citrus-it citrus-it Awaiting requested review from citrus-it citrus-it is a code owner

@oetiker oetiker Awaiting requested review from oetiker oetiker is a code owner

@hadfl hadfl Awaiting requested review from hadfl hadfl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@extrowerk @hadfl @oetiker