Use Nanobot's new config format + model provider dialects by calvinmclean · Pull Request #6246 · obot-platform/obot

calvinmclean · 2026-04-08T22:11:49Z

This PR updates Obot to consume Nanobot's new provider dialect and llmProviders config format introduced in nanobot-ai/nanobot#263.

Addresses #6195

What Changed

Provider dialect support

Reads the dialect field from model provider tool metadata rather than inferring the LLM client type from model name
Adds Dialect field to CommonProviderMetadata in the API types

Per-agent provider config

Introduces NANOBOT_PROVIDER_CONFIG as a dynamic file credential injected into nanobot agent containers
Builds a nanobot.yaml-format provider config containing only the LLM providers actually used by the agent (no more unconditionally injecting both OPENAI_API_KEY and ANTHROPIC_API_KEY)
The config is written into .nanobot/nanobot.yaml inside the agent workspace volume via an init container (Docker and Kubernetes)

Type consolidation in MCP backend

Replaces locally defined nanobot config structs with imported types from github.com/nanobot-ai/nanobot/pkg/types and pkg/mcp

Dependencies

Depends on Add provider dialects and provider configuration; unify agents directory + nanobot.yaml nanobot-ai/nanobot#263 — currently uses a replace directive pointing at a local path; will be updated to the released version once that PR is merged
Depends on Add Dialect to model providers tools#797 for the dialect field in model provider tool definitions (optional)

Copilot

Pull request overview

This PR updates Obot to integrate Nanobot's new provider dialect system and per-agent provider configuration format. The changes enable Obot to read LLM provider dialects from tool metadata rather than relying on heuristics, and to dynamically configure only the providers actually needed by each agent.

Changes:

Replaces locally-defined nanobot config structs with imported types from github.com/nanobot-ai/nanobot/pkg/types
Adds Dialect field to CommonProviderMetadata in API types for declaring provider API formats
Introduces per-agent provider configuration via NANOBOT_PROVIDER_CONFIG dynamic file credential
Adds init containers to inject provider configs into agent workspaces (Docker and Kubernetes)
Refactors model resolution to capture provider info and dialect for each LLM model
Updates function names from generic "constructNanobotYAML" to specific "constructMCPServerNanobotYAML" for clarity

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/mcp/backend.go	Replaces local types with nanobot pkg types; consolidates nanobot config construction logic
pkg/mcp/docker.go	Adds init container support for provider config injection; refactors repetitive init container code
pkg/mcp/kubernetes.go	Adds init container for provider config injection into agent workspaces
pkg/controller/handlers/nanobotagent/nanobotagent.go	Refactors model resolution to include provider and dialect info; builds provider-specific config YAML
pkg/controller/handlers/nanobotagent/nanobotagent_test.go	Updates tests to work with new `resolvedLLMModel` return type
apiclient/types/modelprovider.go	Adds `Dialect` field to `CommonProviderMetadata`
go.mod	Updates dependencies and adds local replace directive for nanobot (temporary)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

pkg/mcp/docker.go:1

workspaceCreated is returned as true even when VolumeCreate returns AlreadyExists (race with another creator). That defeats the “only run for initial creation” gating and can cause unexpected init behavior. Return false on AlreadyExists (or re-check existence and set workspaceCreated accordingly) so the boolean accurately reflects whether this call created the volume.

package mcp

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

g-linville · 2026-04-14T14:27:32Z

Oh, also, for message policies: right now there is nothing there that would handle chat completions, but it should work with Responses and Anthropic (and OpenResponses if it is identical to Responses). I don't think it necessarily needs to be made to work with chat completions in this same PR, but I wanted to call that out because it is something that will need to get done.

calvinmclean · 2026-04-14T15:00:57Z

Oh, also, for message policies: right now there is nothing there that would handle chat completions, but it should work with Responses and Anthropic (and OpenResponses if it is identical to Responses). I don't think it necessarily needs to be made to work with chat completions in this same PR, but I wanted to call that out because it is something that will need to get done.

@g-linville I didn't think we wanted to support chat completions. Maybe I misunderstood

g-linville · 2026-04-14T15:03:53Z

@calvinmclean Oh, I'm not sure if we want to or not. I was assuming that we were because I saw it was one of the dialect types. But if we aren't going to actually support it with any model providers, then yeah we don't need to do it for message policies.

Copilot

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Write .nanobot/nanobot.yaml llmProviders * Simplify docker volume/container inits with runInitContainer * Update some naming to make it clear it is MCP config only * Use Nanobot types when building config * Dynamically build the nanobot.yaml for selected model * Derive Dialect from provider meta * Fix name shadowing * Update go.mod using remote branch * Generate * Fix default proxy for ChatCompletions and add tests * Fix provider config reload with symbolic link * Improve function naming * Improve function naming and other minor changes * Improve ensureCredentials refresh logic * Add Dialect to ModelManifest * regenerate * Always run link for docker * Revert use of nanobottypes * PR comments * Move all config setup to nanobotagent.go * fix boolean condition per copilot comment * Fix error retry check

* Use Nanobot's new config format + model provider dialects (#6246) * Write .nanobot/nanobot.yaml llmProviders * Simplify docker volume/container inits with runInitContainer * Update some naming to make it clear it is MCP config only * Use Nanobot types when building config * Dynamically build the nanobot.yaml for selected model * Derive Dialect from provider meta * Fix name shadowing * Update go.mod using remote branch * Generate * Fix default proxy for ChatCompletions and add tests * Fix provider config reload with symbolic link * Improve function naming * Improve function naming and other minor changes * Improve ensureCredentials refresh logic * Add Dialect to ModelManifest * regenerate * Always run link for docker * Revert use of nanobottypes * PR comments * Move all config setup to nanobotagent.go * fix boolean condition per copilot comment * Fix error retry check * Add Bifrost provider dialect and enable model providers in UI (#6358) * Add Bifrost provider dialect * Enable bedrock provider in UI * Enable Ollama in UI * Enable Azure, AzureEntra in UI * Update docs * Update Nanobot branch * Improve docs for Azure Entra * fix go mod issue * Resolve PR comments * fix go mod * Improve Ollama networking doc for linux users * Remaining changes: message policies, dependencies, etc. WIP deps Rename NANOBOT_CONFIG_PATH => NANOBOT_CONFIG Fix MessagePolicy for Bifrost Extract and reuse message policies code Include env in BackPopulateModels - This allows the Azure provider to get updated deployments Update kinm + nah improve docs lint generate Improve URL handling * Update pkg/gateway/server/llmproxy.go Co-authored-by: Donnie Adams <donnie@obot.ai> * fix after suggestion applied * Revert "Update pkg/gateway/server/llmproxy.go" This reverts commit 320a47b. * Revert "fix after suggestion applied" This reverts commit 0281a84. * Update Nanobot --------- Co-authored-by: Donnie Adams <donnie@obot.ai>

calvinmclean mentioned this pull request Apr 8, 2026

Add Dialect to model providers obot-platform/tools#797

Merged

calvinmclean commented Apr 8, 2026

View reviewed changes

Comment thread pkg/mcp/backend.go Outdated

calvinmclean requested a review from Copilot April 8, 2026 22:26

Copilot started reviewing on behalf of calvinmclean April 8, 2026 22:27 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread pkg/mcp/backend.go

Comment thread go.mod Outdated

calvinmclean requested a review from Copilot April 8, 2026 22:40

Copilot started reviewing on behalf of calvinmclean April 8, 2026 22:41 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

calvinmclean commented Apr 10, 2026

View reviewed changes

Comment thread go.mod

calvinmclean force-pushed the feature/provider-config branch from cf926fa to 0dea3fd Compare April 13, 2026 15:53

calvinmclean requested a review from Copilot April 13, 2026 16:08

Copilot started reviewing on behalf of calvinmclean April 13, 2026 16:09 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

calvinmclean changed the base branch from main to feature/llm-providers April 13, 2026 19:53

calvinmclean requested a review from Copilot April 13, 2026 21:23

Copilot started reviewing on behalf of calvinmclean April 13, 2026 21:23 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread apiclient/types/model.go

Comment thread pkg/mcp/docker.go Outdated

Comment thread pkg/mcp/kubernetes.go Outdated

Comment thread pkg/mcp/kubernetes.go Outdated

Comment thread go.mod

calvinmclean added 13 commits April 13, 2026 14:31

Write .nanobot/nanobot.yaml llmProviders

e2aca21

Simplify docker volume/container inits with runInitContainer

e295f32

Update some naming to make it clear it is MCP config only

b3fc90f

Use Nanobot types when building config

263b41d

Dynamically build the nanobot.yaml for selected model

3d1290e

Derive Dialect from provider meta

46ac2a1

Fix name shadowing

ce93dc9

Update go.mod using remote branch

183f177

Generate

2c7e76f

Fix default proxy for ChatCompletions and add tests

e21f6e7

Fix provider config reload with symbolic link

298a8a2

Improve function naming

029835e

Improve function naming and other minor changes

20e6a0e

Always run link for docker

cdc8098

calvinmclean marked this pull request as ready for review April 13, 2026 21:49

calvinmclean requested review from g-linville, njhale and thedadams April 13, 2026 22:02

g-linville reviewed Apr 14, 2026

View reviewed changes

Comment thread pkg/controller/handlers/nanobotagent/nanobotagent.go

Comment thread pkg/mcp/docker.go

thedadams requested changes Apr 14, 2026

View reviewed changes

calvinmclean force-pushed the feature/provider-config branch from d692436 to 3cd0a61 Compare April 14, 2026 19:06

Revert use of nanobottypes

0124b53

calvinmclean force-pushed the feature/provider-config branch from 3cd0a61 to 0124b53 Compare April 14, 2026 19:07

calvinmclean added 2 commits April 14, 2026 12:38

PR comments

18c2eb2

Move all config setup to nanobotagent.go

f731788

calvinmclean requested review from Copilot, g-linville and thedadams April 14, 2026 22:20

Copilot started reviewing on behalf of calvinmclean April 14, 2026 22:20 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread pkg/api/handlers/nanobotagent.go Outdated

Comment thread pkg/mcp/docker.go

Comment thread pkg/controller/handlers/nanobotagent/nanobotagent.go

fix boolean condition per copilot comment

0459ee4

thedadams reviewed Apr 16, 2026

View reviewed changes

Comment thread pkg/api/handlers/nanobotagent.go Outdated

Comment thread pkg/mcp/docker.go

Fix error retry check

948607a

thedadams approved these changes Apr 16, 2026

View reviewed changes

calvinmclean merged commit 002da94 into obot-platform:feature/llm-providers Apr 16, 2026

calvinmclean deleted the feature/provider-config branch April 16, 2026 14:47

Conversation

calvinmclean commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Dependencies

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

g-linville commented Apr 14, 2026

Uh oh!

calvinmclean commented Apr 14, 2026

Uh oh!

g-linville commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

calvinmclean commented Apr 8, 2026 •

edited

Loading