feat: add optional name to httproute rules#407
Open
tboerger wants to merge 1 commit intooauth2-proxy:mainfrom
Open
feat: add optional name to httproute rules#407tboerger wants to merge 1 commit intooauth2-proxy:mainfrom
tboerger wants to merge 1 commit intooauth2-proxy:mainfrom
Conversation
tboerger
force-pushed
the
feat/gateway-rule-name
branch
from
15139d5 to
b8c794b
Compare
In order to apply security policies from gateway api implementations like Envoy Gateway to the HTTPRoute I have added an optional name attribute to the rules. These name attributes can be matched by the sectionName of other resources. Signed-off-by: Thomas Boerger <thomas@webhippie.de>
tboerger
force-pushed
the
feat/gateway-rule-name
branch
from
b8c794b to
ab4af24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to apply security policies from gateway api implementations like Envoy Gateway to the HTTPRoute I have added an optional name attribute to the rules. These name attributes can be matched by the sectionName of other resources.
As an example this can't match without a named rule to specific rules:
Checklist: