fix(__internal) : fix slash problem in oldfiles#3260
fix(__internal) : fix slash problem in oldfiles#3260jamestrew merged 2 commits intonvim-telescope:masterfrom
Conversation
- Problems Problem with slash and backslash being mixed up is chronic issue of neovim in Windows. it makes telescope prompt perceive same path differently when it execute to oldfiles picker. some function like `nvim_buf_get_name()` or `vim.v.oldfiles` give paths which are mixed up with slash and backslash. - What it did For windows, it always needs to change slash(/) to backslash(\) when function which deal with path because entry_maker works properly only the case that path string has \ not /. - Effect 1) oldfiles picker doesn't show duplicated list 2) `defaults.path_display` configuration feature will works well at oldfiles pikcer
|
Sorry is this the same fix as #3103 |
|
@jamestrew |
|
Sorry I must've confused you with a comment I deleted about plenary. I just wanted to confirm that this fixes the same issue as #3103 -- seems like a simpler fix so I'd probably prefer this PR over #3103 if that's alright. I would probably just ask to remove all but the first |
|
Ok, New commit is uploaded with erased comments except of first one. |
|
Thanks! |
Description
Problem with slash and backslash being mixed up is chronic issue of neovim in Windows. it makes telescope prompt perceive same path differently when it execute to oldfiles picker.
some function like
nvim_buf_get_name()orvim.v.oldfilesgive paths which are mixed up with slash and backslash.it always needs to change slash(/) to backslash() when function which deal with path because entry_maker works properly only the case that path string has \ not /.
defaults.path_displayconfiguration feature will works well at oldfiles pikcerFixes #1683
It is related with PR #3103 what i submitted but opened
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
(before the issue is fixed, the path which has slash and backslash being mixed up cannot be applied by path_display
even though
vim.opt.shellslashistrueI checked with formatter stylua also and add some simple comment about it
Configuration:
Checklist: