Skip to content

Add Canary support#55

Open
anand-nv wants to merge 5 commits intonvidia-riva:release/2.18.0from
anand-nv:canary_support
Open

Add Canary support#55
anand-nv wants to merge 5 commits intonvidia-riva:release/2.18.0from
anand-nv:canary_support

Conversation

@anand-nv
Copy link
Copy Markdown

@anand-nv anand-nv commented Oct 30, 2024

Add support for canary models

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
@anand-nv anand-nv requested review from atomer-nvidia and rmittal-github and removed request for rmittal-github October 30, 2024 14:25
Comment thread nemo2riva/schema.py Outdated
Comment thread nemo2riva/patches/aed_canary.py Outdated
Comment thread nemo2riva/patches/aed_canary.py
Comment thread nemo2riva/patches/aed_canary.py Outdated
Comment thread nemo2riva/cookbook.py
Comment thread nemo2riva/schema.py Outdated
Comment thread nemo2riva/validation_schemas/asr-scr-exported-aedmodel.yaml Outdated
Comment thread nemo2riva/patches/aed_canary.py Outdated
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Comment thread nemo2riva/schema.py
schema_dict = None

supported_formats = ["ONNX", "CKPT", "TS", "NEMO"]
supported_formats = ["ONNX", "CKPT", "TS", "NEMO", "PYTORCH", "STATE"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add separate "PYTORCH" as supported format or can we use "CKPT" for it?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PYTORCH in case we are just exporting part of the model or tensors.

Comment thread requirements.txt Outdated
nvidia-eff-tao-encryption>=0.1.8
nvidia-pyindex==1.0.6
onnx==1.14.1
onnx==1.16.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would the same versions as Riva container work here?

torch 2.5.0
onnx 1.17.0

will be good them same to avoid any possible discrepancies due to version mismatches b/w nemo and Riva.

@rmittal-github rmittal-github changed the base branch from main to release/2.18.0 November 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants