*: build multi-arch docker images linux/amd64,linux/arm64#1355
Merged
mreiferson merged 1 commit intonsqio:masterfrom Aug 15, 2021
Merged
*: build multi-arch docker images linux/amd64,linux/arm64#1355mreiferson merged 1 commit intonsqio:masterfrom
mreiferson merged 1 commit intonsqio:masterfrom
Conversation
danbf
force-pushed
the
multi-arch
branch
4 times, most recently
from
94f6887 to
7c196d1
Compare
danbf
changed the title
mreiferson
requested changes
Aug 13, 2021
Member
mreiferson
left a comment
mreiferson
left a comment
There was a problem hiding this comment.
I'll give this a test run, seems like a good time for a stable release ;)
mreiferson
changed the title
This was referenced Aug 14, 2021
Merged
mreiferson
approved these changes
Aug 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
current nsq images don't support arm64 architecture. that means we can't run them on AWS Graviton's or Apple M1's natively.
Solution
use buildx to build a multi-arch with
linux/amd64,linux/arm64platform support.the biggest change is we have to go from separate build and push steps into a single build and push step. this is because the local docker doesn't support building locally multi-arch images.
Notes
based on https://www.docker.com/blog/multi-arch-images/ and https://www.docker.com/blog/multi-arch-build-what-about-circleci/
our upstreams, both
golang:latestand alpine:3.10`` support these architectures and more.addresses: #1306