sm_ipt: Provide zephyr porting layer by dchat-nordic · Pull Request #5191 · nrfconnect/sdk-nrf

dchat-nordic · 2021-07-27T10:10:01Z

Updated zephyr porting layer for
nrf_rpc.
Added zephyr layer for sm_ipt (shared memory
inter-processor transport).

Depends on:
nrfconnect/sdk-nrfxlib#524
nrfconnect/sdk-nrfxlib#525

Signed-off-by: Dominik Chat dominik.chat@nordicsemi.no

CLAassistant · 2021-07-27T10:10:05Z

All committers have signed the CLA.

NordicBuilder · 2021-08-04T11:47:10Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

KAGA164 · 2021-08-11T14:47:57Z

subsys/CMakeLists.txt

 add_subdirectory(partition_manager)

 add_subdirectory_ifdef(CONFIG_NRF_RPC nrf_rpc)
+add_subdirectory(sm_ipt)


Should it be added always ?

KAGA164 · 2021-08-11T14:51:18Z

subsys/sm_ipt/CMakeLists.txt

+
+zephyr_library()
+
+zephyr_library_sources_ifdef(CONFIG_SM_IPT sm_ipt_os.c)


Maybe just:

Suggested change

zephyr_library_sources_ifdef(CONFIG_SM_IPT sm_ipt_os.c)

zephyr_library_sources(sm_ipt_os.c)

Add conditionally add sm_ipt directory CONFIG_SM_IPT

KAGA164 · 2021-08-11T14:52:18Z

subsys/sm_ipt/include/sm_ipt_os.h

+typedef struct k_mutex sm_ipt_os_mutex_t;
+#define sm_ipt_os_mutex_init k_mutex_init
+#define sm_ipt_os_unlock k_mutex_unlock
+static inline void sm_ipt_os_lock(sm_ipt_os_mutex_t *mutex) {


Please add blank line above

KAGA164 · 2021-08-11T14:52:32Z

subsys/sm_ipt/include/sm_ipt_os.h

+
+typedef struct k_sem sm_ipt_os_sem_t;
+#define sm_ipt_os_give k_sem_give
+static inline void sm_ipt_os_sem_init(sm_ipt_os_sem_t *sem) {


Please add blank line above

KAGA164 · 2021-08-11T14:53:31Z

subsys/sm_ipt/sm_ipt_os.c

+static void ipm_callback(const struct device *ipmdev, void *user_data, uint32_t id,
+			 volatile void *data)
+{
+	struct sm_ipt_os_ctx *os_ctx;


Suggested change

struct sm_ipt_os_ctx *os_ctx;

struct sm_ipt_os_ctx *os_ctx = (struct sm_ipt_os_ctx *) user_data;

Add you can remove next line

KAGA164 · 2021-08-11T14:53:49Z

subsys/sm_ipt/sm_ipt_os.c

+	struct sm_ipt_os_ctx *os_ctx;
+	os_ctx = (struct sm_ipt_os_ctx *) user_data;
+
+	if (os_ctx->signal_handler != NULL)


Suggested change

if (os_ctx->signal_handler != NULL)

if (os_ctx->signal_handler)

KAGA164 · 2021-08-11T14:54:39Z

subsys/sm_ipt/sm_ipt_os.c

+int sm_ipt_os_init(struct sm_ipt_os_ctx *os_ctx)
+{
+	const struct device *ipm_rx_handle;
+	uint32_t size = (SHM_SIZE / 8) * 4;


You can use solution from Zephyr

KAGA164 · 2021-08-11T14:57:34Z

subsys/nrf_rpc/include/nrf_rpc_log.h

 #define _NRF_RPC_LOG_REGISTER1(module) \
 	_NRF_RPC_LOG_REGISTER2(module)

+#define _NRF_RPC_LOG_DECLARE2(module) \


Why we need those two levels of macro ?

If I were to use only level 2, then "CONFIG_ ## module ## _LOG_LEVEL", would result in appending name of module macro, not its value. Level 1 makes sure to pass only value of level 1s define.

github-actions · 2021-08-20T10:20:57Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
nrfxlib	nrfconnect/sdk-nrfxlib@`d048f58`	nrfconnect/sdk-nrfxlib#525	nrfconnect/sdk-nrfxlib#525/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

doki-nordic · 2021-08-23T13:35:15Z

subsys/nrf_rpc/include/nrf_rpc_os.h

Don't update date, if the file was not changed.

doki-nordic · 2021-08-25T07:29:01Z

west.yml

More convenient is following syntax. If you use it, you don't need to update this line each time dependent PR changes:

revision: pull/524/head

When dependent PR goes into master, you can remove this change.

Updated zephyr porting layer for nrf_rpc. Added zephyr layer for sm_ipt (shared memory inter-processor transport). Signed-off-by: Dominik Chat <dominik.chat@nordicsemi.no> Co-authored-by: Dominik Kilian <Dominik.Kilian@nordicsemi.no>

DatGizmo · 2022-03-16T11:36:07Z

With the new Integration Test Specification process we don't need the github labels.
I will remove them.

Right now this PR runs all Integration tests because it changes sdk-nrfxlib in west.yml and there is no test-spec.yml in that repo yet.
You can add changes to this PR nrfconnect/sdk-nrfxlib#687 to make the test spec here more targeted

To get the test spec feature working correctly on this PR, you need to rebase it to the latest main to get the .github/test-spec.yml file

Then run CI here to update the test spec.

Information about the test spec feature
CI-Help for issues

github-actions bot added CI-matter-test changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 27, 2021

NordicBuilder added the external External contribution label Jul 27, 2021

nrfconnect deleted a comment from NordicBuilder Aug 10, 2021

dchat-nordic removed the external External contribution label Aug 10, 2021

dchat-nordic force-pushed the add_sm_ipt branch from e313402 to f4d0e13 Compare August 11, 2021 09:46

KAGA164 requested review from KAGA164 and doki-nordic August 11, 2021 09:55

KAGA164 suggested changes Aug 11, 2021

View reviewed changes

dchat-nordic force-pushed the add_sm_ipt branch from f4d0e13 to edb523b Compare August 20, 2021 10:20

github-actions bot added manifest CI-all-test Run All integration tests manifest-nrfxlib labels Aug 20, 2021

dchat-nordic force-pushed the add_sm_ipt branch from edb523b to f4bb9c6 Compare August 20, 2021 11:06

github-actions bot added CI-all-test Run All integration tests and removed CI-all-test Run All integration tests labels Aug 20, 2021

doki-nordic requested changes Aug 25, 2021

View reviewed changes

dchat-nordic force-pushed the add_sm_ipt branch from f4bb9c6 to 6e04a98 Compare August 25, 2021 11:19

github-actions bot added CI-all-test Run All integration tests DNM and removed CI-all-test Run All integration tests labels Aug 25, 2021

dchat-nordic force-pushed the add_sm_ipt branch from 6e04a98 to ec0964e Compare August 26, 2021 07:51

github-actions bot removed the CI-all-test Run All integration tests label Aug 26, 2021

sm_ipt: Provide os porting layer

a952c57

Updated zephyr porting layer for nrf_rpc. Added zephyr layer for sm_ipt (shared memory inter-processor transport). Signed-off-by: Dominik Chat <dominik.chat@nordicsemi.no> Co-authored-by: Dominik Kilian <Dominik.Kilian@nordicsemi.no>

dchat-nordic force-pushed the add_sm_ipt branch from ec0964e to a952c57 Compare August 26, 2021 08:30

github-actions bot added the CI-all-test Run All integration tests label Aug 26, 2021

DatGizmo removed CI-all-test Run All integration tests CI-matter-test labels Mar 16, 2022

dchat-nordic closed this Mar 16, 2022


		zephyr_library()

		zephyr_library_sources_ifdef(CONFIG_SM_IPT sm_ipt_os.c)

	zephyr_library_sources_ifdef(CONFIG_SM_IPT sm_ipt_os.c)
	zephyr_library_sources(sm_ipt_os.c)

	struct sm_ipt_os_ctx *os_ctx;
	struct sm_ipt_os_ctx os_ctx = (struct sm_ipt_os_ctx ) user_data;

	if (os_ctx->signal_handler != NULL)
	if (os_ctx->signal_handler)

Conversation

dchat-nordic commented Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Aug 4, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DatGizmo commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dchat-nordic commented Jul 27, 2021 •

edited

Loading

CLAassistant commented Jul 27, 2021 •

edited

Loading

github-actions bot commented Aug 20, 2021 •

edited

Loading