feat: add courier to novu migrate page#1064
Conversation
✅ Deploy Preview for docs-novu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new "Migrate from Courier to Novu" guide, updates docs navigation to include the new guide, and simplifies MDX frontmatter title strings in the framework overview file. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content/docs/guides/migrate-from-courier-to-novu.mdx`:
- Line 3: The front-matter pageTitle string "Migrate from Courier to Novu" has
trailing whitespace after the closing quote; remove the extra space so the line
reads exactly pageTitle: "Migrate from Courier to Novu" (update the pageTitle
line in the file to eliminate the trailing whitespace).
- Around line 155-187: The Python code fence has inconsistent indentation;
reformat the entire fenced block so every line is consistently indented (match
surrounding guide examples), e.g., indent all lines within the triple-backtick
by two spaces so imports, the with Novu(...) as novu: block, the call to
novu.trigger(trigger_event_request_dto=novu_py.TriggerEventRequestDto(...)), and
subsequent nested dictionaries (to, payload, overrides) align properly; ensure
symbols like Novu, novu.trigger, TriggerEventRequestDto and the res/print(res)
lines are preserved but moved to the consistent indentation level.
- Around line 42-43: Add a blank line between the table row ending with "Novu
will automatically filter the notifications for the tenant and the end user will
see only the notifications relevant to their tenant." and the horizontal rule
`---`; locate the `---` horizontal rule in the migrate-from-courier-to-novu.mdx
content and insert a single empty line immediately before it so the table is
properly terminated and Markdown renders correctly.
- Around line 229-245: Update the Inbox card's href in the Cards block: locate
the Card component with title "Inbox Integration" and change its href prop from
"/platform/inbox/overview" to "/platform/inbox" so it points to the inbox index
page while leaving the other Card hrefs unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e913a6f7-f8e5-4200-9c78-8ab8beb65fab
📒 Files selected for processing (3)
content/docs/framework/index.mdxcontent/docs/guides/meta.jsoncontent/docs/guides/migrate-from-courier-to-novu.mdx
DianaHackmamba
left a comment
There was a problem hiding this comment.
Starting with a few high-level format issues.
Click the circling arrows when you are ready for me to take another look.
Summary by CodeRabbit