Replace local sphinx_mintlify with PyPI package#770
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (11)
WalkthroughAdded a local pre-commit hook Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c340251 to
c6ab5bc
Compare
|
✅ Eval complete for commit
Ran evals with prompts: 📈 +4.6 pts · Getting Started — C (72.3/100) from C (67.7) · View metricsPrompt text:
Verdict:
Friction points:
Result: C (72.3/100) delta vs baseline: +4.6 pts
Stats: 2m 35s · 22 tool calls · 1 error · 1 interruption · $0.95 Evaluating agent experience using 2027.dev · View dashboard |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
73-73: Pinsphinx-mintlifyexactly for reproducible docs builds.Line 73 uses a floating lower bound (
>=0.1.0). Keeping it ranged can cause docs drift across environments as new plugin versions are released. The locked version is currently 0.1.0, so pinning exactly would maintain the intended behavior.Proposed change
- "sphinx-mintlify>=0.1.0", + "sphinx-mintlify==0.1.0",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 73, Change the dependency specification for sphinx-mintlify from a ranged requirement to an exact pin: replace "sphinx-mintlify>=0.1.0" with an exact version "sphinx-mintlify==0.1.0" in the pyproject.toml dependencies so docs builds remain reproducible; ensure you update the same dependency entry where "sphinx-mintlify>=0.1.0" appears.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Line 73: Change the dependency specification for sphinx-mintlify from a ranged
requirement to an exact pin: replace "sphinx-mintlify>=0.1.0" with an exact
version "sphinx-mintlify==0.1.0" in the pyproject.toml dependencies so docs
builds remain reproducible; ensure you update the same dependency entry where
"sphinx-mintlify>=0.1.0" appears.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 751d147b-8c9b-4abb-a325-e2d4b1351beb
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
.pre-commit-config.yamldocs/src/sdk-reference/remotesession/__init__.mdxmakefilepyproject.toml
💤 Files with no reviewable changes (1)
- makefile
This comment has been minimized.
This comment has been minimized.
Switch from `uv pip install -e ../sphinx_mintlify` to the published `sphinx-mintlify` PyPI package as a dev dependency. Add a pre-commit hook that regenerates SDK reference docs when SDK source files change, ensuring documentation stays in sync. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes type rendering in generated docs: Literal values now have proper quotes, Optional is rendered as modern `X | None` syntax, fully-qualified pydantic types are simplified, and Callable signatures are properly shown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update Literal type formatting in manual session.mdx to match the corrected output from sphinx-mintlify 0.1.1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d3a30bb to
497aeef
Compare
Summary
sphinx-mintlifyto PyPI and replaced the local editable install (uv pip install -e ../sphinx_mintlify) with a proper dev dependencydocs-sdkMakefile targetdocs-sdk-generatepre-commit hook that regenerates SDK reference docs when SDK source files or Sphinx config change, ensuring docs stay in syncTest plan
sphinx-mintlifypublished and installable from PyPI (pip install sphinx-mintlify==0.1.0)uv lockresolves the package successfullymake docs-sdkto verify SDK docs generate correctly without local package🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation
Greptile Summary
This PR migrates
sphinx-mintlifyfrom a local editable install (uv pip install -e ../sphinx_mintlify) to a proper PyPI package (sphinx-mintlify==0.1.0) pinned in dev dependencies, and adds adocs-sdk-generatepre-commit hook to keep SDK reference docs in sync with source changes. The dependency migration and lock file look correct. The only notable concern is thatcheck-sdk-docsis ordered beforedocs-sdk-generatein.pre-commit-config.yaml, which can require two commit attempts when SDK source and docs are both out of sync.Confidence Score: 5/5
Safe to merge — all findings are P2 style/workflow suggestions with no correctness or data-integrity risk.
The dependency migration is straightforward and the lock file hashes are verified. Both comments are P2: hook ordering is a developer UX concern (not a broken workflow), and the missing smoke test is a best-practice note for a tooling-only change.
.pre-commit-config.yaml — hook ordering between check-sdk-docs and docs-sdk-generate is worth revisiting.
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Replace local sphinx_mintlify install wi..." | Re-trigger Greptile
Context used: