Open
Conversation
…Instara plugin. 2. Update preference update logic. 3. Update insert logic with order of sgvId ascending.
Author
|
@MilosKozak Would you please review this PR? Thanks. |
# Conflicts: # plugins/sync/src/main/res/values-zh-rCN/strings.xml
|
Author
@MilosKozak Should I change the target branch to dev3 instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Instara CGM Link:
https://play.google.com/store/apps/details?id=com.teljane.instara
Main changes
Add files to support a new kind of CGM: Instara, with the following functions:
Development Notes
pumpIdto storesgvId, with notes to avoid confusion.devicePrefix,sgvMark,sgvStartinto preference xml. For the same device, only insert once. When the user changes to a new device, this part of information will be updated.Test
Currently a few users are using this version and it works as expected. We'll continue the test.