Skip to content

Medtrum: Improve BLE connection recovery using handler thread #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HuismanErik wants to merge 2 commits into
base: dev
Choose a base branch
from
+8 −6
Open

Medtrum: Improve BLE connection recovery using handler thread #4582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbbcb53
Medtrum: Improve BLE connection recovery using handler thread
HuismanErik Mar 5, 2026
519d0df
Medtrum: Move state flag resets into close() to prevent race condition
HuismanErik Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pump/medtrum/src/main/kotlin/app/aaps/pump/medtrum/services/BLEComm.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ class BLEComm @Inject internal constructor(
} else {
aapsLogger.debug(LTag.PUMPBTCOMM, "Not connected, closing gatt")
close()
isConnected = false
mCallback?.onBLEDisconnected()
}
}
Expand All @@ -198,6 +197,8 @@ class BLEComm @Inject internal constructor(
mBluetoothGatt?.close()
SystemClock.sleep(100)
mBluetoothGatt = null
isConnected = false
isConnecting = false
}

/** Scan callback */
Expand Down Expand Up @@ -387,11 +388,12 @@ class BLEComm @Inject internal constructor(
// Wait a bit before retrying
SystemClock.sleep(2000)
}
close()
isConnected = false
isConnecting = false
mCallback?.onBLEDisconnected()
aapsLogger.debug(LTag.PUMPBTCOMM, "Device was disconnected " + gatt.device.name) //Device was disconnected
// CLosing asynchronously to avoid deadlocks or silent failures in the Android BLE callback thread during disconnect.
handler.post {
close()
mCallback?.onBLEDisconnected()
aapsLogger.debug(LTag.PUMPBTCOMM, "Device was disconnected " + gatt.device.name) //Device was disconnected
}
}
}

Expand Down