Skip to content

Omnipod DASH - adressing race condition on connection startup AAPS 3.3.2.1 Android 16 #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanmegen wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Omnipod DASH - adressing race condition on connection startup AAPS 3.3.2.1 Android 16 #4313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29322ab
guarding disconnect() with a catch-all and logging to prevent missing…
fmegen Nov 5, 2025
efd569b
changing dispatcher to IO
fmegen Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...dash/src/main/kotlin/app/aaps/pump/omnipod/dash/driver/comm/callbacks/BleCommCallbacks.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ import app.aaps.core.utils.toHex
import app.aaps.pump.omnipod.dash.driver.comm.io.CharacteristicType.Companion.byValue
import app.aaps.pump.omnipod.dash.driver.comm.io.IncomingPackets
import app.aaps.pump.omnipod.dash.driver.comm.session.DisconnectHandler
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.delay
import kotlinx.coroutines.launch
import java.util.UUID
import java.util.concurrent.BlockingQueue
import java.util.concurrent.CountDownLatch
Expand Down Expand Up @@ -38,7 +42,14 @@ class BleCommCallbacks(
aapsLogger.debug(LTag.PUMPBTCOMM, "OnConnectionStateChange with status/state: $status/$newState")
super.onConnectionStateChange(gatt, status, newState)
if (newState == BluetoothProfile.STATE_CONNECTED && status == BluetoothGatt.GATT_SUCCESS) {
connected.countDown()
aapsLogger.debug(LTag.PUMPBTCOMM, "OnConnectionStateChange delaying gattConnected event by $SLEEP_AFTER_CONNECT_GATT ms")
CoroutineScope(Dispatchers.Main).launch {
Copy link
Copy Markdown
Contributor

@MilosKozak MilosKozak Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dispatchers.Main is used for UI operation
change to Dispatchers.IO

Copy link
Copy Markdown
Author

@vanmegen vanmegen Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MilosKozak Updated to Dispatchers.IO

// give GATT a chance to configure encrypt, race condition bt stack.
delay(SLEEP_AFTER_CONNECT_GATT)
aapsLogger.debug(LTag.PUMPBTCOMM, "OnConnectionStateChange now delivering gattConnected")

connected.countDown()
}
}
if (newState == BluetoothProfile.STATE_DISCONNECTED) {
// If status == SUCCESS, it means that we initiated the disconnect.
Expand Down Expand Up @@ -225,5 +236,7 @@ class BleCommCallbacks(
companion object {

private const val WRITE_CONFIRM_TIMEOUT_MS = 10 // the confirmation queue should be empty anyway

const val SLEEP_AFTER_CONNECT_GATT = 1000L
}
}