Add hints process directive for executor-specific scheduling hints#7034
Draft
pditommaso wants to merge 2 commits intomasterfrom
Draft
Add hints process directive for executor-specific scheduling hints#7034pditommaso wants to merge 2 commits intomasterfrom
pditommaso wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Introduce a new map-type `hints` process directive that provides a structured, extensible way for pipeline authors to pass executor-specific scheduling hints. Keys use `[executor/][scope.]hintName` format. Core features: - Multiple `hints` calls within a process body accumulate (merge) - Config overrides via withName:/withLabel: replace the entire map - Values support String, Integer, and Closure types - Two-tier validation: warnings for unknown unprefixed keys (global registry), errors for unknown executor-prefixed keys - Initial global catalog contains only `consumableResource` Seqera Platform integration: - `seqera/machineRequirement.*` hints map to MachineRequirementOpts fields (arch, provisioning, maxSpotAttempts, machineTypes, diskType, diskThroughputMiBps, diskIops, diskEncrypted, diskAllocation, diskMountPath, diskSize, capacityMode) - Hints override Seqera config scope values at the task level - Unknown `seqera/` keys produce an error Ref: #5917, #6960 Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hintsprocess directive for executor-specific scheduling hints[executor/][scope.]hintNameformat (e.g.seqera/machineRequirement.arch)machineRequirement.*fields mapped toMachineRequirementOptsContext
Follows the refined ADR proposal from #6960 (comment). Replaces fragile
clusterOptionsand overloadedext/resourceLabelsworkarounds.Ref: #5917, #6960
Test plan
ProcessBuilderTest— hints registration, accumulation, duplicate key overwrite, closure storageTaskConfigTest—getHints()retrieval, empty map default, config override replacementHintDefsTest— global registry validation, fuzzy "did you mean?" matching, value type validationHintHelperTest— all 12machineRequirement.*field mappings, overlay precedence, unknown key error, non-seqera hint ignoringNXF_SMOKE=1 ./gradlew :nextflow:test)🤖 Generated with Claude Code