-
Notifications
You must be signed in to change notification settings - Fork 783
Add resourceAllocation field to trace record #6973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
bf06da9
Add resourceAllocation field to trace record
pditommaso 052c0b6
Revert "Add accelerator request to trace record (#6703)"
pditommaso 63a908b
Merge branch 'master' into add-resource-allocation-trace-field
pditommaso a8677a6
Bump sched-client to 0.47.0 (#6987) [ci fast]
pditommaso 601c3f0
Bump org.apache.groovy from 4.0.30 to 4.0.31 (#6985) [ci fast]
pditommaso 4fd5903
Docs: document Wave support for module resources directory (#6984) [c…
pditommaso d5ce609
Remove stale reference to soon-to-be EOL'd AWS Linux 2 (#6970) [ci skip]
clintval c50e75d
Use inline metadata from trace create response (#6976)
pditommaso 8c52655
Replace Auth0 with Platform OIDC PKCE for auth login (#6953)
pditommaso 9ea212d
Document workflow output lineage types (#6972)
jorgee a8687cb
docs: Add output labels use cases and details (#6986)
christopher-hakkaart a0b4319
docs: Improve process directive docs (#6990)
christopher-hakkaart ae10318
Typed workflows (#6881)
bentsherman 3249b51
Add `module create` subcommand (#6992)
pditommaso 4cd2ea2
Add `module validate` subcommand (#6993)
pditommaso ab50174
Add `module spec` command (#6859)
jorgee 93924a8
docs: Add migration guide reference to legacy operators page (#7010)
adamrtalbot c460529
Use npr-client API instead of custom ModuleRegistryClient (#7012) [ci…
pditommaso 6b73c70
Restore accelerator and accelerator_type fields in TraceRecord
pditommaso 9ce5af5
Populate accelerator trace fields from task config and update tests
pditommaso f5f840c
Merge branch 'master' into add-resource-allocation-trace-field
pditommaso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,9 +103,7 @@ class TraceRecord implements Serializable { | |
| vol_ctxt: 'num', // -- /proc/$pid/status field 'voluntary_ctxt_switches' | ||
| inv_ctxt: 'num', // -- /proc/$pid/status field 'nonvoluntary_ctxt_switches' | ||
| hostname: 'str', | ||
| cpu_model: 'str', | ||
| accelerator: 'num', | ||
| accelerator_type: 'str' | ||
| cpu_model: 'str' | ||
| ] | ||
|
|
||
| static public Map<String,Closure<String>> FORMATTER = [ | ||
|
|
@@ -125,6 +123,7 @@ class TraceRecord implements Serializable { | |
| transient private ContainerMeta containerMeta | ||
| transient private Integer numSpotInterruptions | ||
| transient private String logStreamId | ||
| transient private Map<String,Object> resourceAllocation | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not blocking, but the naming is a bit awkward. how about
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Eventually, it's prefer to keep aligned to sched naming for now |
||
|
|
||
| /** | ||
| * Convert the given value to a string | ||
|
|
@@ -638,4 +637,12 @@ class TraceRecord implements Serializable { | |
| void setContainerMeta(ContainerMeta meta) { | ||
| this.containerMeta = meta | ||
| } | ||
|
|
||
| Map<String,Object> getResourceAllocation() { | ||
| return resourceAllocation | ||
| } | ||
|
|
||
| void setResourceAllocation(Map<String,Object> value) { | ||
| this.resourceAllocation = value | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.