Skip to content

feat: update loading shares of table #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luka-nextcloud wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −7
Open

feat: update loading shares of table #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Controller/ShareController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function __construct(


#[NoAdminRequired]
#[RequirePermission(permission: Application::PERMISSION_READ, type: Application::NODE_TYPE_TABLE, idParam: 'tableId')]
#[RequirePermission(permission: Application::PERMISSION_MANAGE, type: Application::NODE_TYPE_TABLE, idParam: 'tableId')]
public function index(int $tableId): DataResponse {
return $this->handleError(function () use ($tableId) {
$shares = $this->service->findAll('table', $tableId);
Expand All @@ -48,7 +48,7 @@ public function index(int $tableId): DataResponse {
}

#[NoAdminRequired]
#[RequirePermission(permission: Application::PERMISSION_READ, type: Application::NODE_TYPE_VIEW, idParam: 'viewId')]
#[RequirePermission(permission: Application::PERMISSION_MANAGE, type: Application::NODE_TYPE_VIEW, idParam: 'viewId')]
public function indexView(int $viewId): DataResponse {
return $this->handleError(function () use ($viewId) {
$shares = $this->service->findAll('view', $viewId);
Expand Down
12 changes: 7 additions & 5 deletions src/modules/main/sections/Dashboard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,13 @@ export default {
},

async loadShares() {
// load shares for table
this.loadingTableShares = true
const allTableShares = await this.getSharesForTableFromBE(this.table.id)
this.tableShares = allTableShares.filter(s => !isPublicLinkShare(s))
this.loadingTableShares = false
if (this.canManageElement(this.table)) {
// load shares for table
this.loadingTableShares = true
const allTableShares = await this.getSharesForTableFromBE(this.table.id)
this.tableShares = allTableShares.filter(s => !isPublicLinkShare(s))
this.loadingTableShares = false
}

// load shares for all views
this.loadingViewShares = true
Expand Down
Loading