Skip to content

fix(external-link): threading#16782

Open
alperozturk96 wants to merge 2 commits intomasterfrom
fix/anr-external-link-provider
Open

fix(external-link): threading#16782
alperozturk96 wants to merge 2 commits intomasterfrom
fix/anr-external-link-provider

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

Issue

"main" tid=1 Timed Waiting
  at jdk.internal.misc.Unsafe.park (Native method)
  at java.util.concurrent.locks.LockSupport.parkNanos (LockSupport.java:269)
  at android.database.sqlite.SQLiteConnectionPool.waitForConnection (SQLiteConnectionPool.java:796)
  at android.database.sqlite.SQLiteConnectionPool.acquireConnection (SQLiteConnectionPool.java:402)
  at android.database.sqlite.SQLiteSession.acquireConnection (SQLiteSession.java:931)
  at android.database.sqlite.SQLiteSession.beginTransactionUnchecked (SQLiteSession.java:332)
  at android.database.sqlite.SQLiteSession.beginTransaction (SQLiteSession.java:311)
  at android.database.sqlite.SQLiteDatabase.beginTransaction (SQLiteDatabase.java:845)
  at android.database.sqlite.SQLiteDatabase.beginTransaction (SQLiteDatabase.java:828)
  at android.database.sqlite.SQLiteDatabase.beginTransaction (SQLiteDatabase.java:681)
  at androidx.sqlite.db.framework.FrameworkSQLiteDatabase.beginTransaction (FrameworkSQLiteDatabase.android.kt:52)
  at com.owncloud.android.providers.FileContentProvider.query (FileContentProvider.java:454)
  at android.content.ContentProvider.query (ContentProvider.java:1670)
  at android.content.ContentProvider.query (ContentProvider.java:1766)
  at android.content.ContentProvider$Transport.query (ContentProvider.java:304)
  at android.content.ContentResolver.query (ContentResolver.java:1269)
  at android.content.ContentResolver.query (ContentResolver.java:1200)
  at android.content.ContentResolver.query (ContentResolver.java:1155)
  at com.owncloud.android.datamodel.ExternalLinksProvider.getExternalLink (ExternalLinksProvider.java:74)
  at com.owncloud.android.ui.activity.DrawerActivity.updateExternalLinksInDrawer (DrawerActivity.java:953)
  at com.owncloud.android.ui.activity.DrawerActivity.openDrawer (DrawerActivity.java:721)
  at com.owncloud.android.ui.activity.FileDisplayActivity.onOptionsItemSelected (FileDisplayActivity.kt:1309)
  at android.app.Activity.onMenuItemSelected (Activity.java:4814)
  at androidx.activity.ComponentActivity.onMenuItemSelected (ComponentActivity.kt:477)
  at androidx.fragment.app.FragmentActivity.onMenuItemSelected (FragmentActivity.java:264)
  at androidx.appcompat.app.AppCompatActivity.onMenuItemSelected (AppCompatActivity.java:256)
  at androidx.appcompat.view.WindowCallbackWrapper.onMenuItemSelected (WindowCallbackWrapper.java:109)

Changes

  • Converts Java to Kotlin
  • Uses CoroutineScope to make DB call on background thread and access result on main thread

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/anr-external-link-provider branch from 9264364 to d4d85fb Compare March 31, 2026 08:14
@github-actions
Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3938
Correctness7070
Dodgy code231231
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total442441

@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/23787380028/artifacts/6195123328
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant