Issue #39 | ClickhouseTable: integration tests#43
Open
IceKhan13 wants to merge 19 commits intoneuralinkcorp:mainfrom
Open
Issue #39 | ClickhouseTable: integration tests#43IceKhan13 wants to merge 19 commits intoneuralinkcorp:mainfrom
IceKhan13 wants to merge 19 commits intoneuralinkcorp:mainfrom
Conversation
Collaborator
|
@IceKhan13 is this PR ready for review? |
Contributor
Author
|
@houqp yes, it is! |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces integration tests for ClickHouse table functionality and reorganizes the test structure. The implementation adds a new dependency (ibis-framework) to replace connectionx for database connectivity, which provides better compatibility and broader backend support.
- Adds comprehensive integration tests for ClickHouseTable with Docker Compose setup
- Reorganizes test structure separating functional and integration tests
- Replaces polars.read_database_uri with ibis for ClickHouse connectivity
Reviewed Changes
Copilot reviewed 8 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/test_clickhouse_table_int.py | New integration test suite with comprehensive ClickHouse table testing scenarios |
| test/integration/resources/docker-compose.yml | Docker Compose configuration for ClickHouse test environment |
| test/functional/test_core.py | Updated import paths to reflect new test structure |
| test/functional/tables/test_clickhouse_table.py | Updated mocks to use ibis instead of polars.read_database_uri |
| test/functional/roapi/test_roapi.py | Updated import paths for new test structure |
| src/datarepo/core/tables/clickhouse_table.py | Replaced polars.read_database_uri with ibis.connect for database queries |
| pyproject.toml | Added ibis-framework and clickhouse-driver dependencies |
| .github/workflows/build_and_publish.yml | Added integration test workflow with Docker Compose setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration tests for Clickhouse table
Details
P.S.
Connectionx was also pain to work with as polars + connectionx + clickhouse has a lot of conflicting dependencies (and it looks like it was working through mysql anyway).