Skip to content

Update debug trace logs and code comments#3388

Open
jimklimov wants to merge 25 commits intonetworkupstools:masterfrom
jimklimov:issue-3302-logs-comments
Open

Update debug trace logs and code comments#3388
jimklimov wants to merge 25 commits intonetworkupstools:masterfrom
jimklimov:issue-3302-logs-comments

Conversation

@jimklimov
Copy link
Copy Markdown
Member

@jimklimov jimklimov commented Apr 1, 2026

  • Clarify NSS error messages in server and various client code paths
  • Better logging to make sense of of upsd mainloop()
  • Another public API bump for this release, with upscli_sendline_timeout_may_disconnect() and upscli_readline_timeout_may_disconnect() methods

Primarily cleaning PR #3368 from non-functional changes made during investigation for issue #3302 which account for a lot of diff noise. Any significant code changes (to the logic) are delayed till next release.

…(driver, client...) [networkupstools#3302]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…, or that it failed and we would sleep 0.1s [networkupstools#3302]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…OSIX and WIN32, revise logging disconnect events for POSIX [networkupstools#3302]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ctionable error messages [networkupstools#3302, networkupstools#1711]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…t() when projected err_len>0, and request the right size right away

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ther variants of this code

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov added this to the 2.8.5 milestone Apr 1, 2026
@jimklimov jimklimov added enhancement documentation SSL/NSS Issues and PRs about SSL, TLS and other crypto-related matters NUT protocols labels Apr 1, 2026
@jimklimov jimklimov changed the title Update docs, debug trace logs, comments Update debug trace logs and code comments Apr 1, 2026
@jimklimov jimklimov force-pushed the issue-3302-logs-comments branch 2 times, most recently from 5cb05c5 to c75320f Compare April 1, 2026 14:42
@AppVeyorBot
Copy link
Copy Markdown

jimklimov added 12 commits April 2, 2026 12:48
…cognized, but pertain to another build configuration [networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…le their timing [networkupstools#3379, networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ake() [networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…itialised SSL client [networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…#3302]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ebug messages, update comments [networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…_ERR_SSLERR when (Open)SSL read/write fails during/despite retry loop [networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…k and report errno from select/read/write failures more diligently [networkupstools#3379, networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…or() from read/write failures more diligently, and handle "ERR*" replies with separate logging [networkupstools#3379, networkupstools#3331]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…t(): report "disconnecting" explicitly [networkupstools#3379]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ct timeout default [networkupstools#2847]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…r say OK Goodbye [networkupstools#3302, networkupstools#1711]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…e_timeout_may_disconnect() [networkupstools#3302]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov force-pushed the issue-3302-logs-comments branch from c75320f to 6a8cfbb Compare April 2, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement NUT protocols SSL/NSS Issues and PRs about SSL, TLS and other crypto-related matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants