Update debug trace logs and code comments#3388
Open
jimklimov wants to merge 25 commits intonetworkupstools:masterfrom
Open
Update debug trace logs and code comments#3388jimklimov wants to merge 25 commits intonetworkupstools:masterfrom
jimklimov wants to merge 25 commits intonetworkupstools:masterfrom
Conversation
…(driver, client...) [networkupstools#3302] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…, or that it failed and we would sleep 0.1s [networkupstools#3302] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…OSIX and WIN32, revise logging disconnect events for POSIX [networkupstools#3302] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…oop [networkupstools#3302, networkupstools#3365, networkupstools#3376] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…networkupstools#3368] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ctionable error messages [networkupstools#3302, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…t() when projected err_len>0, and request the right size right away Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ther variants of this code Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
5cb05c5 to
c75320f
Compare
|
✅ Build nut 2.8.4.4433-master completed (commit 74f805f3a7 by @jimklimov) |
…tssl.c [networkupstools#3302, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…netssl.c [networkupstools#3302, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rkupstools#3379, networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…cognized, but pertain to another build configuration [networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…le their timing [networkupstools#3379, networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ake() [networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…itialised SSL client [networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…#3302] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ebug messages, update comments [networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…_ERR_SSLERR when (Open)SSL read/write fails during/despite retry loop [networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…k and report errno from select/read/write failures more diligently [networkupstools#3379, networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…or() from read/write failures more diligently, and handle "ERR*" replies with separate logging [networkupstools#3379, networkupstools#3331] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…t(): report "disconnecting" explicitly [networkupstools#3379] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ct timeout default [networkupstools#2847] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…r say OK Goodbye [networkupstools#3302, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…e_timeout_may_disconnect() [networkupstools#3302] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
c75320f to
6a8cfbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upsdmainloop()upscli_sendline_timeout_may_disconnect()andupscli_readline_timeout_may_disconnect()methodsPrimarily cleaning PR #3368 from non-functional changes made during investigation for issue #3302 which account for a lot of diff noise. Any significant code changes (to the logic) are delayed till next release.
-Dhandling to all interactive NUT programs #3382 was merged