BUGFIX: Disallow singleton route part handlers#3485
Open
bwaidelich wants to merge 1 commit into8.3from
Open
Conversation
Using singleton route part handlers can have severe side effects because they are shared between all route instances. This change leads to an exception being thrown if a singleton handler is configured Related: neos/neos-development-collection#5571
Member
Author
|
DISCLAIMER: I changed this code in the browser, didn't test it yet! |
kitsunet
approved these changes
Jun 14, 2025
Member
kitsunet
left a comment
kitsunet
left a comment
There was a problem hiding this comment.
I guess that's fine... Haven't tested but should work.
If you need a shared runtime cache that can always be a singleton you inject into the handler or so...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using singleton route part handlers can have severe side effects because they are shared between all route instances.
This change leads to an exception being thrown if a singleton handler is configured
Related: neos/neos-development-collection#5571