Open
Conversation
kitsunet
approved these changes
Apr 1, 2025
Member
kitsunet
left a comment
kitsunet
left a comment
There was a problem hiding this comment.
Fine by me, thanks for noticing!
Note for later: We should probably take care of having cache here again. Haven't looked into the history but I assume way back we used a shutdown object function to turn the array of newExpressions into cache entries but that is no longer the case. We should probably look at \Neos\Eel\CompilingEvaluator::evaluate() on how to deal with cache...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3395
Without the fix, there are warnings in current PHP versions.