Skip to content

Simplify commitlint invokation & version generation #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knocte merged 3 commits into from
Apr 5, 2026
Merged

Simplify commitlint invokation & version generation #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20f653a
GitHubCI: simplify commitlint step
knocte Apr 5, 2026
658c511
version.config: bump to signal "almost 0.8"
knocte Apr 5, 2026
f98e864
scripts/publish.fsx: simplify fullVersion calc
knocte Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
rm -rf conventions/.git/
- name: Validate current commit (last commit) with commitlint
if: github.event_name == 'push'
run: ./conventions/commitlint.sh --from HEAD~1 --to HEAD --verbose
run: ./conventions/commitlint.sh --last --verbose
- name: Validate PR commits with commitlint
if: github.event_name == 'pull_request'
run: ./conventions/commitlint.sh --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose
Expand Down
23 changes: 2 additions & 21 deletions scripts/publish.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,28 +72,9 @@ let fullVersion =
baseVersion
| _ -> ()

let nugetPush =
Path.Combine(rootDir.FullName, "Tools", "nugetPush.fsx")
|> FileInfo

// to disable welcome msg, see https://stackoverflow.com/a/70493818/544947
Environment.SetEnvironmentVariable("DOTNET_NOLOGO", "true")

let fullVersion =
Process
.Execute(
{
Command = "dotnet"
Arguments =
sprintf
"fsi %s --output-version %s"
nugetPush.FullName
baseVersion
},
Echo.Off
)
.UnwrapDefault()
.Trim()
Fsdk.Network.GetNugetPrereleaseVersionFromBaseVersion
baseVersion

fullVersion

Expand Down
2 changes: 1 addition & 1 deletion version.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
BaseVersion=0.6.1
BaseVersion=0.7.99
Loading