-
Notifications
You must be signed in to change notification settings - Fork 12
A new rule that makes sure the user have explained the reason of reverting #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tehraninasab
wants to merge
9
commits into
nblockchain:master
from
tehraninasab:properRevertMessage-squashed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
696d5ca
commitlintplugings.test: add one failing test
tehraninasab db4b14e
commitlint.config: proper revert message rule
tehraninasab fcc01a5
commitlint.config: set defaultIgnores to false
tehraninasab 704840b
.gitignore: add f# related files to .gitignore
tehraninasab a41b482
commitlint.config: use workaround for new rule
tehraninasab 3b8ae8c
commitlintplugins.test: add another test
tehraninasab 576c9a4
commitlintplugins.test: edit test commit msg
tehraninasab 8c94b24
commitlintplugins.test: fix test message
tehraninasab 938bc4c
commitlintplugins.test: fix the test msg
tehraninasab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need the workaround here if the tests don't involve references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, but shouldn't I add a test that involves references? I thought it was possible in revert messages too