-
Notifications
You must be signed in to change notification settings - Fork 12
Easy dotnet conventions to verify #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tehraninasab
wants to merge
29
commits into
nblockchain:master
from
tehraninasab:verifyDotnetConventions-squashed
Closed
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
50fe215
FileConventions: add failing test
tehraninasab 186213e
FileConventions: implement the function
tehraninasab 2ebd2b5
FileConventions: add failing test
tehraninasab cc82850
FileConventions: implement the function
tehraninasab a0272d6
FileConventions: add failing test
tehraninasab 482d4d6
FileConventions: implement the function
tehraninasab 5f06394
FileConventions.Test: add failing test
tehraninasab 12f4d0b
FileConventions: fix the function
tehraninasab b0acb0c
FileConventions: add failing test
Mersho 7823ab2
FileConventions: fix csharp namespace
Mersho 9b8afb3
FileConventions: add failing test
Mersho 21f3749
FileConventions: `Contains()` is not suitable here
Mersho 81bfb57
FileConventions: use BetterAssert() & update Fsdk
Mersho e124a91
FileConventions(.Test): applying f# standard style
Mersho eb5f76c
FileConventions: add failing test
Mersho 885a60a
FileConventions: fix the function
Mersho 4e0c6e1
FileConventions: add failing test
Mersho 6e80056
FileConvention: fix the function
Mersho 46f3dae
FileConventions: add failing test
Mersho 45e298b
FileConvention: fix the function
Mersho c190f9c
FileConventions(.Test): fix proj file indent
Mersho d49a99c
FileConvention: properly naming variables
Mersho 19b442d
FileConventions: add failing test
Mersho e6fc879
FileConvention: fix the function
Mersho 5358b96
FileConventions.Test: add failing test
Mersho ce4c0c6
FileConventions: fix empty string false-positives
Mersho 18b828e
FileConventions: load Helpers.fs first
Mersho 1fd7576
FileConventions: improvements to Library.fs
Mersho a326d09
FileConventions: dotnetFileConvention
Mersho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
src/FileConventions.Test/DummyFiles/DummyScriptWithConventionalEmptyString.fsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #!/usr/bin/env -S dotnet fsi | ||
|
|
||
| open System | ||
| open System.IO | ||
|
|
||
| let emptyString = String.Empty |
6 changes: 6 additions & 0 deletions
6
src/FileConventions.Test/DummyFiles/DummyScriptWithNonConventionalEmptyString.fsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #!/usr/bin/env -S dotnet fsi | ||
|
|
||
| open System | ||
| open System.IO | ||
|
|
||
| let emptyString = "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -586,3 +586,29 @@ let IsExecutableTest2() = | |
| )) | ||
|
|
||
| Assert.That(IsExecutable fileInfo, Is.EqualTo false) | ||
|
|
||
|
|
||
| [<Test>] | ||
| let DefiningEmptyStringsWithDoubleQuotes1() = | ||
| let fileInfo = | ||
| (FileInfo( | ||
| Path.Combine( | ||
| dummyFilesDirectory.FullName, | ||
| "DummyScriptWithConventionalEmptyString.fsx" | ||
| ) | ||
| )) | ||
|
|
||
| Assert.That(DefiningEmptyStringsWithDoubleQuotes fileInfo, Is.EqualTo false) | ||
|
|
||
|
|
||
| [<Test>] | ||
| let DefiningEmptyStringsWithDoubleQuotes2() = | ||
| let fileInfo = | ||
| (FileInfo( | ||
|
||
| Path.Combine( | ||
| dummyFilesDirectory.FullName, | ||
| "DummyScriptWithNonConventionalEmptyString.fsx" | ||
| ) | ||
| )) | ||
|
|
||
| Assert.That(DefiningEmptyStringsWithDoubleQuotes fileInfo, Is.EqualTo true) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra parens