Skip to content

fix: apply withCredentials for sync requests (#168) #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hoang130203 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

fix: apply withCredentials for sync requests (#168) #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,12 @@ function _createXHR(options) {
xhr.ontimeout = errorFunc
xhr.open(method, uri, !sync, options.username, options.password)
//has to be after open
if(!sync) {
xhr.withCredentials = !!options.withCredentials
}
// Set withCredentials for both sync and async requests when explicitly requested.
// Previously this was guarded by `if (!sync)` to work around a Firefox crash
// when withCredentials was always forced on sync requests. Setting it only when
// the caller opts in (options.withCredentials is truthy) is safe in all modern
// browsers for both sync and async. See: https://github.com/naugtur/xhr/issues/168
xhr.withCredentials = !!options.withCredentials
// Cannot set timeout with sync request
// not setting timeout on the xhr object, because of old webkits etc. not handling that correctly
// both npm's request and jquery 1.x use this kind of timeout, so this is being consistent
Expand Down