/* */ comments don't exist in Sass, ending is determined by indent [attempt 2]#46
Open
szhu wants to merge 1 commit intonathos:sublimefrom
szhu:sublime
Open
/* */ comments don't exist in Sass, ending is determined by indent [attempt 2]#46szhu wants to merge 1 commit intonathos:sublimefrom szhu:sublime
szhu wants to merge 1 commit intonathos:sublimefrom
szhu:sublime
Conversation
From http://sass-lang.com/documentation/file.INDENTED_SYNTAX.html: “Comments beginning with /* are preserved in the CSS output, although unlike SCSS they don’t require a closing */.” Take 2; this time Sass and SCSS syntaxes are separated.
Owner
|
I'm going to put this on hold for now, rolling everything back to 0dc1707 until we figure out a better method of supporting both SCSS & indented syntaxes, and a better method for testing these pull requests. |
|
Hello, this pull request #50 resolve the problem of many comment lines over SASS syntax without affect to SCSS syntax, while you decide split both syntaxes. |
Author
|
That looks promising. Can you fix the indents (file uses tabs but you used spaces)? Not that important but I feel like someone's going to complain down the line. |
|
Sorry, Github editor has betrayed me. Fixed ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #42, except that SCSS syntax won't be changed; it is now in a separate file.
Still has the same flaw that Sass block comments aren't being properly highlighted, but at least it doesn't gray out the rest of the document:
