feat: Let constructor fixtures return narwhals object directly#3569
Open
FBruzzesi wants to merge 5 commits intofeat/testing-constructorsfrom
Open
feat: Let constructor fixtures return narwhals object directly#3569FBruzzesi wants to merge 5 commits intofeat/testing-constructorsfrom
FBruzzesi wants to merge 5 commits intofeat/testing-constructorsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alright, at this point I briefly mention this branch to all of you @MarcoGorelli @dangotbanned @camriddell so I might as well open the PR.
I think it is promising, but I might need some help for the typing, here is a repro for the issue I am facing:
which seems far from ideal! I didn't manage to get the
__call__overload quite right, but it should not be far from the correct solution. I tried a few other variations without success.Regarding the patches in
conftest.py:narwhals(main namespace) the default namespace to the__call__method and avoid having to pass it everywhere. This works sincenw.from_nativecan also take a narwhals object