[Scorecards] Added fix for filter where the url has a type of council#795
Open
lucascumsille wants to merge 1 commit intomasterfrom
Open
[Scorecards] Added fix for filter where the url has a type of council#795lucascumsille wants to merge 1 commit intomasterfrom
lucascumsille wants to merge 1 commit intomasterfrom
Conversation
… argument Currently, in a single section page where we display a message advising users the Combined Authorities don't have this section, the link "Show all Combined Authority sections" takes them to `/sections/?type=combined` however this URL does not activate the filter in the sections page to display only the CA. This commit takes in account the arguments in the URL, so the right option is chosen when loading the page
zarino
reviewed
Feb 9, 2026
Member
zarino
left a comment
zarino
left a comment
There was a problem hiding this comment.
This works, but it would be nice to do this without JavaScript somehow. Especially since we’re using a query param (which Django can access, so therefore could modify the returned page itself, no JavaScript required) 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in a single section page where we display a message advising users the Combined Authorities don't have this section, the link "Show all Combined Authority sections" takes them to
/sections/?type=combinedhowever this URL does not activate the filter in the sections page to display only the CA.This commit takes in account the arguments in the URL, so the right option is chosen when loading the page
Screen.Recording.2026-02-09.at.07.35.29.mov