[textfield] Use non-native label for <TextField select/>#47958
Open
mj12albert wants to merge 2 commits intomui:masterfrom
Open
[textfield] Use non-native label for <TextField select/>#47958mj12albert wants to merge 2 commits intomui:masterfrom
<TextField select/>#47958mj12albert wants to merge 2 commits intomui:masterfrom
Conversation
mj12albert
added
type: bug
mj12albert
changed the title
<TextField select/>
Netlify deploy previewhttps://deploy-preview-47958--material-ui.netlify.app/ Bundle size report
|
mj12albert
added
breaking change
mj12albert
force-pushed
the
fix/textfield-select-label
branch
from
b7a4fad to
dd591cf
Compare
siriwatknp
reviewed
Mar 13, 2026
| props: ({ ownerState }) => ownerState.formControl, | ||
| style: { | ||
| 'label + &': { | ||
| [`.${inputLabelClasses.root} + &`]: { |
Member
There was a problem hiding this comment.
Note that this increases specificity from (0,1,0) to (0,2,0) might break some customization.
Member
There was a problem hiding this comment.
can you try:
Suggested change
| [`.${inputLabelClasses.root} + &`]: { | |
| [`label + &, div:where(.${inputLabelClasses.root}) + &`]: { |
Member
Author
There was a problem hiding this comment.
Updated to: [`label + &, :where(.${inputLabelClasses.root}) + &`] without the div (in case it's a span or sth)
With :where, the new selector is even less specific than the original one, so it could be ok to drop the label + & one as this PR is marked breaking anyway 🤔
Member
Author
There was a problem hiding this comment.
(the preview works, dunno why Argos is getting an error or stuck on an old snapshot)
mj12albert
force-pushed
the
fix/textfield-select-label
branch
from
155b34f to
afffdab
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
fix/textfield-select-label
branch
from
35af8d8 to
4028882
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
fix/textfield-select-label
branch
3 times, most recently
from
49b1c2c to
96c18cc
Compare
mj12albert
force-pushed
the
fix/textfield-select-label
branch
from
96c18cc to
70c9981
Compare
| 'label + &': { | ||
| marginTop: 16, | ||
| }, | ||
| [`label + &, :where(.${inputLabelClasses.root}) + &, div:where(.${inputLabelClasses.root}) + &`]: |
Member
There was a problem hiding this comment.
I see label is needed when native select with TextField is used. But why div is also needed? Couldn't it be simplified to:
Suggested change
| [`label + &, :where(.${inputLabelClasses.root}) + &, div:where(.${inputLabelClasses.root}) + &`]: | |
| [`label + &, :where(.${inputLabelClasses.root}) + &`]: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking: The visible text label uses a
divinstead of alabelelement for<TextField select/>Part of #47489
Preview: https://deploy-preview-47958--material-ui.netlify.app/material-ui/react-text-field/#select
Avoids devtool errors about incorrect use of the label element; it's not strictly needed as the component is named with
aria-labelledbyalready.