ARM: dts: qcom: msm8226-samsung-matisse-common: move accelerometer and touchscreen node into common dtsi#16
Conversation
wonderfulShrineMaidenOfParadise
left a comment
wonderfulShrineMaidenOfParadise
left a comment
There was a problem hiding this comment.
Newer dt-bindings
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
Outdated
Show resolved
Hide resolved
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
Outdated
Show resolved
Hide resolved
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
Outdated
Show resolved
Hide resolved
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
Outdated
Show resolved
Hide resolved
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
Outdated
Show resolved
Hide resolved
|
So this is confirmed working on matisselte? |
| regulator-min-microvolt = <3300000>; | ||
| regulator-max-microvolt = <3300000>; | ||
|
|
||
| gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>; |
There was a problem hiding this comment.
don't put something in common that's not common, if you override it for 50% of the boards. You could keep gpio empty with a comment that it needs to be filled in by the dts.
Check msm8916 setups, they probably have something like that
There was a problem hiding this comment.
you do need to set them in matisselte though, not just remove them from common
| }; | ||
|
|
||
| tsp_en1_default_state: tsp-en1-default-state { | ||
| pins = "gpio32"; |
no rly but they seem to be mosty the same expect for some gpio pin |
touchscreen node into common dtsi I checked the downstream. Accelerometer and touchscreen node in the downstream device tree of matisselte matisse-wifi are quite similar.Therefore they should be in the common dtsi. Signed-off-by: Karl Chan <exkc@exkc.moe>
I don't really want to merge something that hasn't even been tested... Can you find someone who has a matisselte? |
3 participants
I checked the downstream.
Accelerometer and touchscreen node in the downstream device tree of matisselte matisse-wifi are quite similar.Therefore they should be in the common dtsi.