allow disabling the "quick" keyword for generated pf fw rules#380
Open
Luiggi33 wants to merge 2 commits intomrash:masterfrom
Open
allow disabling the "quick" keyword for generated pf fw rules#380Luiggi33 wants to merge 2 commits intomrash:masterfrom
Luiggi33 wants to merge 2 commits intomrash:masterfrom
Conversation
this is needed to match the packets after passing the rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a config flag to the access stanza that allows generated pf firewall rules to omit the "quick" keyword.
By default, fwknop pf rules include "quick" to skip all other rules. When this option is enabled, the keyword is not inserted, allowing packets to continue through the normal top-to-bottom pf rule evaluation.
Omitting the "quick" keyword allows for more complex packet handling with for example NAT matching in the if-bound mode
Touched up version of #379