Modified launch files tutorial, added a note to the README.#1008
Open
Jakeisthesnake wants to merge 5 commits intomoveit:mainfrom
Open
Modified launch files tutorial, added a note to the README.#1008Jakeisthesnake wants to merge 5 commits intomoveit:mainfrom
Jakeisthesnake wants to merge 5 commits intomoveit:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Launch File tutorial
Added explanations for the member function of MoveItConfigsBuilder.
Added note about launch nodes for custom .cpp files.
Having made these suggestions, I now wonder if I am being too verbose and just cluttering up the documentation when someone wanting to learn more can do what I did and read the source code. So maybe the launch file tutorial should remain unchanged.
README
Added a note that building MoveIt can be skipped if only adding explanations, note any executable code. This is mostly addressing my own pain of building MoveIt (about a 3-4 hour process) and I could see it stopping someone from adding a few helpful comments.
Please explain the changes you made, including a reference to the related issue if applicable
Checklist