Skip to content

Modified launch files tutorial, added a note to the README.#1008

Open
Jakeisthesnake wants to merge 5 commits intomoveit:mainfrom
Jakeisthesnake:main
Open

Modified launch files tutorial, added a note to the README.#1008
Jakeisthesnake wants to merge 5 commits intomoveit:mainfrom
Jakeisthesnake:main

Conversation

@Jakeisthesnake
Copy link
Copy Markdown
Contributor

Description

Launch File tutorial
Added explanations for the member function of MoveItConfigsBuilder.
Added note about launch nodes for custom .cpp files.
Having made these suggestions, I now wonder if I am being too verbose and just cluttering up the documentation when someone wanting to learn more can do what I did and read the source code. So maybe the launch file tutorial should remain unchanged.

README
Added a note that building MoveIt can be skipped if only adding explanations, note any executable code. This is mostly addressing my own pain of building MoveIt (about a 3-4 hour process) and I could see it stopping someone from adding a few helpful comments.

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants