Conversation
|
I just woke up, so I haven't had time to fully review it, but some initial concerns from me:
Regardless, the implementation here is really clever, well done! Also, feel free to ignore the Nix CI, I can fix that for you. |
|
Regarding 1, moonlight is actually already explicitly detected by Discord (and it's not for malicious reasons) so I don't think this makes much of a difference. It's already disabled by default, and I'm not sure how to add a Danger Zone marking given that it's toggled in moonbase, though an extra warning box is probably reasonable |
That detection doesn't actually trigger since we don't load libdiscore's separate Webpack entrypoint immediately - I've been meaning to solve it in a more pleasant way in #301.
I'm pretty sure having it as a dependency of Moonbase will enable it, given that we don't have a mechanism to do soft dependency resolution ATM. We should probably fix that... Alternatively, we could not integrate it with Moonbase at all and just have a separate settings tab, I guess?
|
Settings are synced directly to Discord, no remote server required :)