Skip to content

fix: double lineJump in zen mode (@nadalaba) #7799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadalaba wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −11
Open

fix: double lineJump in zen mode (@nadalaba) #7799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c14bea
fix double lineJump in zen mode
nadalaba Apr 9, 2026
03ea645
remove unneeded export
nadalaba Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions frontend/src/ts/test/test-ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ const resultWordsHistoryEl = qsr(".pageTest #resultWordsHistory");

export let activeWordTop = 0;
export let activeWordHeight = 0;
export let lineTransition = false;
export let currentTestLine = 0;
let wordTopBeforeLineJump = 0;
let lineTransition = false;
let currentTestLine = 0;
export let resultCalculating = false;

export function setResultCalculating(val: boolean): void {
Expand Down Expand Up @@ -902,7 +903,14 @@ export async function updateWordLetters({
if (!Config.showAllLines) {
const wordTopAfterUpdate = wordAtIndex.getOffsetTop();
if (wordTopAfterUpdate > activeWordTop) {
await lineJump(activeWordTop, true);
let jump = false;
if (!lineTransition) {
wordTopBeforeLineJump = wordTopAfterUpdate;
jump = true;
} else if (wordTopAfterUpdate > wordTopBeforeLineJump) {
jump = true;
}
if (jump) await lineJump(activeWordTop);
}
}
}
Expand Down Expand Up @@ -1163,19 +1171,13 @@ function removeTestElements(lastElementIndexToRemove: number): void {

let currentLinesJumping = 0;

export async function lineJump(
currentTop: number,
force = false,
): Promise<void> {
async function lineJump(currentTop: number, force = false): Promise<void> {
//last word of the line
if (currentTestLine > 0 || force) {
const hideBound = currentTop;

const activeWordEl = getActiveWordElement();
if (!activeWordEl) {
// resolve();
return;
}
if (!activeWordEl) return;

// index of the active word in all #words.children
// (which contains .word/.newline/.beforeNewline/.afterNewline elements)
Expand Down
Loading