feat(typed effect): add tumble typed effect (@d1rshan)#7793
Open
d1rshan wants to merge 4 commits intomonkeytypegame:masterfrom
Open
feat(typed effect): add tumble typed effect (@d1rshan)#7793d1rshan wants to merge 4 commits intomonkeytypegame:masterfrom
d1rshan wants to merge 4 commits intomonkeytypegame:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new tumble typed effect for the test page, with a JS-driven animation that spawns a falling clone of correctly typed words while hiding the original word.
Changes:
- Extend typed effect config schema + settings UI to include
tumble. - Add a new
frontend/src/ts/test/typed-effects.tsmodule to host JS-driven typed effects (currentlytumble). - Wire typed effect lifecycle into
test-ui(trigger on word typed, clear on show/finish) and add corresponding SCSS + keyframes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/schemas/src/configs.ts | Adds tumble to TypedEffectSchema enum. |
| frontend/src/ts/test/typed-effects.ts | Implements JS behavior for tumble (clone + fall animation + cleanup). |
| frontend/src/ts/test/test-ui.ts | Hooks typed-effects into word-typing flow and clears clones/styles on lifecycle events. |
| frontend/src/styles/test.scss | Adds typed-effect-tumble hiding rule + .tumble-clone animation styling. |
| frontend/src/styles/animations.scss | Adds @keyframes typedEffectTumble. |
| frontend/src/html/pages/settings.html | Adds tumble button to typedEffect settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tumble.mp4
This PR adds a new typed effect called tumble.
When a correctly submitted word becomes typed, it creates a temporary animated clone that falls off the screen while the original word is hidden. Incorrect submitted words stay in place so error feedback remains visible.
This PR also introduces a dedicated
typed-effectsmodule for typed effects that need JavaScript behavior, so effect-specific logic does not have to live directly intest-ui.