fix(config): auto-resolve monkey live stats conflicts (@d1rshan)#7715
Merged
Miodec merged 11 commits intomonkeytypegame:masterfrom Apr 8, 2026
Merged
fix(config): auto-resolve monkey live stats conflicts (@d1rshan)#7715Miodec merged 11 commits intomonkeytypegame:masterfrom
Miodec merged 11 commits intomonkeytypegame:masterfrom
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents unsupported UI config combinations that cause the monkey to overlap live stats when those stats use the text style, by blocking the conflicting settings at config-set time and notifying the user (closes #7714).
Changes:
- Add
isBlockedguards + notice toasts forliveSpeedStyle=text/liveAccStyle=textwhenmonkey=true, and for enablingmonkeywhen either live stat style istext. - Add setter-level tests verifying the blocked monkey/liveSpeedStyle combination triggers the expected notice.
- Add metadata-level tests covering blocked combinations for
monkey,liveSpeedStyle, andliveAccStyle.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/ts/config/metadata.ts | Adds isBlocked rules + user notices to prevent monkey + live text stats conflicts. |
| frontend/tests/root/config.spec.ts | Adds tests asserting setConfig rejects conflicting settings and emits the expected notice. |
| frontend/tests/root/config-metadata.spec.ts | Adds table-driven isBlocked coverage for the new conflict rules. |
d1rshan
changed the title
Contributor
Author
Member
|
I think blocking the config change is a bit overkill, but also im not sure whats the best way of handling this. Maybe just allow the overlap and let the user deal with it. |
Miodec
added
waiting for update
Contributor
Author
|
understandable, what if we automatically resolve conflicting settings by disabling the existing one when another is enabled, with a toast to inform the user. (priority for latest selection) |
github-actions
bot
removed
the
waiting for update
Member
|
Thats how confidence and freedom mode work, maybe we could try that 
|
d1rshan
changed the title
Contributor
Author
updated for this behaviour! |
Miodec
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
github-actions
bot
added
the
waiting for review
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling for the invalid monkey + live text stats combination by auto-resolving conflicting settings instead of blocking them.
Behavior:
This follows the existing overrideConfig pattern used for other conflicting settings, where the latest selection takes priority.
Also adds tests to cover these auto-resolved config combinations.
Closes #7714