Improve tests of parsers#586
Merged
sagikazarmark merged 11 commits intomoneyphp:masterfrom Mar 16, 2021
Merged
Conversation
Contributor
Author
|
In short description:
|
Collaborator
|
Why replace mocks with actual implementations? I mean, I understand the usual reasons, but in this case mocks seem acceptable to me. |
Contributor
Author
For the usual reasons.. hahaah
Let's not make a big deal out of it.. if this is no good I will revert.. no problem. |
Collaborator
|
Even if we consider replacing mocks with actual implementations, that should be a separate PR, probably covering the whole library. |
Contributor
Author
|
Revert the test changes about prophesize :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before merging #529 if we could merge this first..