Feat: Convert Molstar Homepage Examples to Mol-view-spec/mol-views-stories#109
Merged
Feat: Convert Molstar Homepage Examples to Mol-view-spec/mol-views-stories#109
Conversation
Collaborator
Author
|
cc: @dsehnal |
Member
|
That's quite the audit :)
MVS does support trajectory files. What's the issue here? |
Collaborator
Author
Wonderful. Do you have an example by any chance? I couldn't quite figure out a pure mvs way to load all the frames. If you can point the way I can update these and the docs as well. |
4 tasks
…coloring - Load XTC trajectory coordinates separately from GRO structure file - Add animation cycling through 100 trajectory frames over 5 seconds - Apply secondary structure coloring to cartoon representation (helices, sheets, loops) - Add transparent surface with low quality for better animation performance - Update description to reflect trajectory animation support
- Load XTC trajectory coordinates separately from GRO structure file - Add animation cycling through 100 trajectory frames over 5 seconds - Add semi-transparent surface (50% opacity) with low quality for performance - Update description to reflect trajectory animation support - Visualization shows conformational changes during tethered agonist exposure
Collaborator
Author
|
After adding molstar/molstar#1783 and getting it into molstar in 5.8, I updated the NPC example which now looks great. I'm going to accept/merge these.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The molstar homepage has a set of beautiful examples. When you click on these examples you load a Molstar instance that loads a
.molxfile which is a zip file containing an assets directory and an internal Molstar state tree. Given that we now have mol-view-stories, we should be able to recreate those exact examples via a Story.Actions
This PR will attempt to convert each of those examples and highlight any potential shortfalls in MVS.
Conversion Approach
Molstar Examples Conversion Status
• Spin/animation not working
• Component names missing on right
• Upstream example had symmetry axes in wrong place
• Missing cage geometry
• Using lines instead of pentagon/triangle
• Need
pdbe-structure-quality-reportwithissue-counttype• Change from
.color({ color: "#4caf50" })to.color({ custom: { pdbe_structure_quality_report: "issue-count" } })Ligand coloring:
• Need element-symbol with chain-based carbon coloring
• Params: saturation: 0, lightness: 0.2
• Check if MVS supports
carbonColorparameter• Gaussian surface of proteins excessively coarse
puttyimplementation• Limited surface options
• Need to update colors
trajectory• Color scheme updates needed
• Alpha channel on surface not working
• Trajectory handling required
Status Legend