Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modelica/Mechanics/MultiBody/Frames/Quaternions/from_T.mo
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ protected
algorithm
/*
This is an optimized version of the quaternion conversion based on
this paper: https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf
this paper: modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this paper: modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf
this paper: https://web.archive.org/web/20170718214714/https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf

*/
if T[3, 3] < 0 then
if T[1, 1] > T[2, 2] then
Expand Down Expand Up @@ -74,7 +74,7 @@ package.
<ul>
<li>January 2021 by Jakub Tobolar<br>
reimplemented for more efficient and numerically stable algorithm according to
<a href=\"https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf\">https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf</a>.
<a href=\"modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href=\"modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.
<a href=\"https://web.archive.org/web/20170718214714/https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.

It compares only one particular diagonal element with another to
select one of the four code parts. Then, the selected code delivers
four components which are close to the desired quaternion,
Expand Down
Binary file not shown.
Loading