-
Notifications
You must be signed in to change notification settings - Fork 44
Handle units of literal constants by means of rules for the empty unit #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henrikt-ma
wants to merge
26
commits into
MCP/0027
Choose a base branch
from
MCP/0027+empty-unit
base: MCP/0027
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7524b11
Initial commit of ReadMe.md for MCP-0027
henrikt-ma 1309d10
Handle units of literal constants by means of rules for the empty unit
henrikt-ma 2dfb4e8
Clarify that all operands of additive operators need to have the same…
henrikt-ma 0c62f41
Clarify "component references outside functions"
henrikt-ma 203c16e
Fix small mistake in example
henrikt-ma 5d42065
Change "common sense" -> "(standard) dimensional analysis"
henrikt-ma fc4abde
Add section with examples of "standard dimensional analysis"
henrikt-ma b86567b
Fix minor typo
henrikt-ma 1f5131c
Put quotes around 'standard dimensional analysis'
henrikt-ma 3291a73
Say "multiplying the operands' units"
henrikt-ma f639afc
Make use of terminology 'dimensional homogenity'
henrikt-ma 3a3b1f0
Don't present lists as "Examples of...", but add "other" item at the end
henrikt-ma e411347
Say "reject or approve"
henrikt-ma f3755a2
Add missing "on"
henrikt-ma fccda32
Reformulate "In some cases"
henrikt-ma 89092ba
Change 'can be' -> 'is'
henrikt-ma 82bb062
Fix typo in comment
henrikt-ma 99ff3c9
Describe unit propagation and elaborate bottom-up nature of unit deri…
henrikt-ma 13529f7
Also describe unit mappings of transcendental functions to match othe…
henrikt-ma 847e645
Change 'are expected to' -> 'should'
henrikt-ma ebfc229
Add example illustrating bottom-up nature of unit inference
henrikt-ma 232c4fa
Make stronger statement about when unit inference takes place
henrikt-ma 9aeb15f
Change example on undefined unit to user-defined function instead of …
henrikt-ma a28b795
Simplify proposal by not omitting rules concerning non-empty units
henrikt-ma 089f554
Move 'Otherwise...' into item list
henrikt-ma 35e4f01
Rule out unit inference for components with empty unit-attribute
henrikt-ma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.