Skip to content

mcp: preserve transport errors in Write error chain #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpugliesi wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

mcp: preserve transport errors in Write error chain #888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa17e7d
mcp: preserve transport errors in error chain using %w instead of %v
jpugliesi Apr 9, 2026
5a3f203
Merge branch 'main' into jpugliesi/wrap-round-tripper-error
jpugliesi Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mcp/streamable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,14 +1782,14 @@ func (c *streamableClientConn) Write(ctx context.Context, msg jsonrpc.Message) e
// Failure to set headers means that the request was not sent.
// Wrap with ErrRejected so the jsonrpc2 connection doesn't set writeErr
// and permanently break the connection.
return nil, nil, fmt.Errorf("%s: %w: %v", requestSummary, jsonrpc2.ErrRejected, err)
return nil, nil, fmt.Errorf("%s: %w: %w", requestSummary, jsonrpc2.ErrRejected, err)
}
resp, err := c.client.Do(req)
if err != nil {
// Any error from client.Do means the request didn't reach the server.
// Wrap with ErrRejected so the jsonrpc2 connection doesn't set writeErr
// and permanently break the connection.
err = fmt.Errorf("%s: %w: %v", requestSummary, jsonrpc2.ErrRejected, err)
err = fmt.Errorf("%s: %w: %w", requestSummary, jsonrpc2.ErrRejected, err)
}
return req, resp, err
}
Expand Down