Skip to content

Add tiffdiff to CMake build system#551

Merged
mm2 merged 2 commits intomasterfrom
copilot/add-tiffdiff-utility-to-cmake
Mar 31, 2026
Merged

Add tiffdiff to CMake build system#551
mm2 merged 2 commits intomasterfrom
copilot/add-tiffdiff-utility-to-cmake

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

tiffdiff was built via the Visual Studio project files but omitted entirely from the CMake build, leaving it unbuildable on non-MSVC toolchains.

Changes

  • cmake/Lcms2Options.cmake — Added LCMS2_BUILD_TIFFDIFF option (ON by default), consistent with the existing LCMS2_BUILD_TIFICC / LCMS2_BUILD_JPGICC pattern.

  • cmake/Lcms2Tools.cmake — Added an optional tiffdiff build block after the tificc block. Shares the same TIFF dependency detection (LCMS2_WITH_TIFF / find_package(TIFF)) and links against TIFF::TIFF (or legacy TIFF_LIBRARIES). The target is registered in LCMS2_TOOL_TARGETS, so it is picked up by the packaging module for installation automatically.

# Optional tiffdiff (requires TIFF).
if(LCMS2_BUILD_TIFFDIFF)
  if(LCMS2_WITH_TIFF)
    find_package(TIFF)
  endif()
  if(TIFF_FOUND)
    _lcms2_add_tool(tiffdiff
      SOURCES
        "${PROJECT_SOURCE_DIR}/utils/tificc/tifdiff.c"
        ${_common_sources}
    )
    ...
  else()
    message(STATUS "TIFF not found or disabled; skipping tiffdiff")
  endif()
endif()

No changes outside the two CMake files.

Copilot AI assigned Copilot and mm2 Mar 31, 2026
Copilot AI linked an issue Mar 31, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add building of tiffdiff utility to CMake scripts Add tiffdiff to CMake build system Mar 31, 2026
Copilot finished work on behalf of mm2 March 31, 2026 15:58
Copilot AI requested a review from mm2 March 31, 2026 15:58
@mm2 mm2 marked this pull request as ready for review March 31, 2026 16:05
Copy link
Copy Markdown
Owner

@mm2 mm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems ok

@mm2 mm2 merged commit 0ec011d into master Mar 31, 2026
32 checks passed
@mm2 mm2 deleted the copilot/add-tiffdiff-utility-to-cmake branch March 31, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In CMake build system, tiffdiff utility is missing.

2 participants