Skip to content

Route incref via vtable to avoid alignment issues#516

Merged
mitsuhiko merged 3 commits intomainfrom
align-dynobj-clone
May 25, 2024
Merged

Route incref via vtable to avoid alignment issues#516
mitsuhiko merged 3 commits intomainfrom
align-dynobj-clone

Conversation

@mitsuhiko
Copy link
Copy Markdown
Owner

This method was previously not sound when the alignment of the type was larger than the necessary alignment for the atomic counters.

@mitsuhiko
Copy link
Copy Markdown
Owner Author

The CI failure is a change in nightly (rust-lang/rust#125319) caused by a new type implementation (rust-lang/rust#99969). Upgrading the time dependency to avoid this issue.

@mitsuhiko mitsuhiko merged commit bffacbf into main May 25, 2024
@mitsuhiko mitsuhiko deleted the align-dynobj-clone branch May 25, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant