-
Notifications
You must be signed in to change notification settings - Fork 3
fix dim() (embedding dimensions) method for qdrant cloud dense encoders #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shanbady
wants to merge
14
commits into
main
Choose a base branch
from
shanbady/cloud-dense-encoder-dense-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b622020
Update qdrant point id keys (#2990)
shanbady 2ef4605
Merge branch 'main' into shanbady/qdrant-upgrade
shanbady e05f9a0
Merge branch 'main' into shanbady/qdrant-upgrade
shanbady 48d37a8
Merge branch 'main' into shanbady/qdrant-upgrade
shanbady 299752c
Vector Search: hybrid search (#3060)
shanbady 7658c30
temporarily pin to _V2 settings for the cutover (#3077)
shanbady 5b0012d
fixing dim() method for qdrant cloud encoder
shanbady bd13b9a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0c7b046
remove print
shanbady bb3d632
Merge branch 'main' into shanbady/cloud-dense-encoder-dense-fix
shanbady 10ac6d9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f160597
Update vector_search/encoders/qdrant_cloud.py
shanbady 8a870fe
Update vector_search/encoders/qdrant_cloud.py
shanbady 6106c83
precommit fixes
shanbady File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have a parametrized unit test for this function but otherwise everything works, LGTM