Fix external links with anchors being rewritten as relative doc links#872
Open
mbeijen wants to merge 2 commits intomitmproxy:mainfrom
Open
Fix external links with anchors being rewritten as relative doc links#872mbeijen wants to merge 2 commits intomitmproxy:mainfrom
mbeijen wants to merge 2 commits intomitmproxy:mainfrom
Conversation
Protect <a href="https?://..."> links from linkify so identifiers in the URL fragment (e.g. #django.http.HttpResponseNotFound) or in the link text are not turned into relative documentation links. Mask such links with placeholders before linkify, then restore them after. Add test_external_link_with_anchor_preserved and testdata module to verify README/included markdown links to external docs with anchors remain intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I tried to setup documentation for a project where I had anchor tags in links in my
README.mdsuch as http://example.com/foobar#baz however the linkification module thought these were code references and it would not render properly. Here my naive bugfix, I hope it helps