Skip to content

browserstack integration#65

Closed
nidhimj22 wants to merge 3 commits intominkphp:masterfrom
nidhimj22:master
Closed

browserstack integration#65
nidhimj22 wants to merge 3 commits intominkphp:masterfrom
nidhimj22:master

Conversation

@nidhimj22
Copy link
Copy Markdown

Added Documentation for integrating with browserStack

@aik099
Copy link
Copy Markdown
Member

aik099 commented Mar 8, 2016

Don't we have mentions of BrowserStack anywhere else?

Comment thread drivers/selenium2.rst Outdated

Check out `BrowserStack's repository`_ for an example integration with BrowserStack.

.. _BrowserStack's repository: https://github.com/browserstack/behat-mink-browserstack
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page doesn't look too helpful. Maybe reference BrowserStack documentation for WebDriver integration instead.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aik099 in the index.rst page?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've meant BrowserStack website: https://www.browserstack.com/automate/capabilities

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the website link also. Let me know if this looks good

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

@nidhimj22 nidhimj22 May 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but don't you feel that the integration is more specific to the Mink extension and can be cloned and run making it easier for the users?
Let me know if you still want me to make the change.

@nidhimj22
Copy link
Copy Markdown
Author

No, there is no BrowserStack reference anywhere else in the documentation.

@aik099
Copy link
Copy Markdown
Member

aik099 commented May 27, 2016

I think you're submitting PR to wrong place. The Mink itself doesn't have any BrowserStack integration. It has MinkSelenium2Driver that can talk WebDriver protocol that in turn can be used to talk to BrowserStack and Sauce Labs.

The libraries that use Mink have integration with BrowserStack and Sauce Labs, e.g.

And it's there documentation where change is needed if BrowserStack/Sauce Labs aren't mentioned in there.

Since the repo you're trying to reference (https://github.com/browserstack/behat-mink-browserstack) is using .behat.yml file, then documentation change should be done for http://docs.behat.org/en/latest/ instead of Mink itself.

The http://phpunit-mink.readthedocs.io/en/latest/getting-started.html page of PHPUnit-Mink documentation already describes show to configure it to be used with both BrowserStack and Sauce Labs.

@nidhimj22
Copy link
Copy Markdown
Author

Yes, makes sense.
I've made changes in this PR to reflect the same. Feel free to close it in case you feel it still doesn't make sense. I'll have a look at the other repos.
Thanks.

@aik099
Copy link
Copy Markdown
Member

aik099 commented May 27, 2016

I'm not watching Behat repo, but I've just noticed that you're already send appropriate PR to Behat docs repo at Behat/docs#99 . I'll close this PR then.

@aik099 aik099 closed this May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants