Add strictSSL support#152
Conversation
|
Are you sure this works? I'm asking because the NodeJS server is created right in the constructor and therefore any call to As discussed in #145 (comment) it would be better to have support for all options at once, rather than 1 of 8. |
|
That's a good point. I went about adding this backwards: added the I'm not sure the best way to have the driver get this without accepting an options array or the like. I have done things where a constructor uses |
The array is absolutely fine, because this way we can account for Zombie options, that will be added in future. We're just trusting that name of option user specified does match the option on Zombie side. Maybe instead of modifying this PR you can send another one, because having PR that's title says "adding 1 option" but in the code it's adding all options is a bit confusing. |
|
@robballou , PR is coming I suppose? |
|
Yeah, sorry. I have started a branch here: https://github.com/robballou/MinkZombieDriver/tree/zombie-options. I haven't had time to really check it out though. Do you want a PR for that and we can hash out changes there? |
|
Sure, you can send a PR from that. |
|
Closing this PR in favor of #154 supporting more options |
Supporting the
strictSSLoption for Zombie allows developers to turn off strict certificate tests that stop self-signed/development certificates in some cases.I still need to figure out how this would be passed in from outside mink itself (from behat for example).