fixes #2218

[mikaelcabot]

See issue for details: #2218

[mikaelcabot]

or could we just assume it's safe to do e.g. (@mikedh) ?

kwargs["vertices"].shape[0]

[mikedh]

Thanks for the PR! Ignoring the spurious failures that will go away when we can drop gmsh haha looks like the corpus model that fails is this one:

Message: 'assimp-c2967cf79acdc4cd48ecb0729e2733bf45b38a6f/test/models/glTF2/glTF-Asset-Generator/Mesh_PrimitiveMode/Mesh_PrimitiveMode_04.gltf'
Arguments: (ValueError('cannot reshape array of size 4 into shape (3)'),)
Traceback (most recent call last):
  File "/home/runner/work/trimesh/trimesh/tests/corpus.py", line 178, in <module>
    report = on_repo(
             ^^^^^^^^
  File "/home/runner/work/trimesh/trimesh/tests/corpus.py", line 118, in on_repo
    raise E
  File "/home/runner/work/trimesh/trimesh/tests/corpus.py", line 70, in on_repo
    m = trimesh.load(
        ^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/trimesh/exchange/load.py", line 126, in load
    loaded = load_mesh(file_obj, file_type=file_type, resolver=resolver, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/trimesh/exchange/load.py", line 202, in load_mesh
    results = loader(file_obj, file_type=file_type, resolver=resolver, **kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/trimesh/exchange/gltf.py", line 326, in load_gltf
    kwargs = _read_buffers(
             ^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/trimesh/exchange/gltf.py", line 1587, in _read_buffers
    raise E
  File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/trimesh/exchange/gltf.py", line 1522, in _read_buffers
    ).reshape((-1, 3))
      ^^^^^^^^^^^^^^^^
ValueError: cannot reshape array of size 4 into shape (3)

[mcadsk]

changed to using

np.size(kwargs["vertices"])

(tested with Mesh_PrimitiveMode_04.gltf 👌 )

[mikedh]

Awesome thanks for the followup looks great!! I'll release in #2220 when that's working. Would it be possible to add a small test model that previously failed just to make sure we don't break this in the future? No worries if not, thanks for the fix!

[mikaelcabot]

Turns out I was a bit quick there, it actually does not work using np.size(kwargs["vertices"]) for
test.glb.zip, but does work with len(kwargs["vertices"]).

[mikaelcabot]

Updated code with tests (cc: @mikedh).