Skip to content

Fix Extension Disable Button Dropdown (#244138) #300218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshithk951 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Extension Disable Button Dropdown (#244138) #300218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf0ac5
Fix Extension Disable Button Dropdown (#244138)
Harshithk951 Mar 9, 2026
992a5af
Merge branch 'main' into main
Harshithk951 Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,6 +1752,7 @@ export class DisableGloballyAction extends ExtensionAction {
if (this.extension && this.extension.local && !this.extension.isWorkspaceScoped && this.extensionService.extensions.some(e => areSameExtensions({ id: e.identifier.value, uuid: e.uuid }, this.extension!.identifier))) {
this.enabled = this.extension.state === ExtensionState.Installed
&& (this.extension.enablementState === EnablementState.EnabledGlobally || this.extension.enablementState === EnablementState.EnabledWorkspace)
&& !this.extensionEnablementService.isDisabledGlobally(this.extension.local)
&& this.extensionEnablementService.canChangeEnablement(this.extension.local);
}
}
Expand Down
21 changes: 21 additions & 0 deletions src/vs/workbench/contrib/extensions/test/electron-browser/extensionsActions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,6 +963,27 @@ suite('ExtensionsActions', () => {
});
});

test('Test DisableGloballyAction when extension is disabled globally and enabled for workspace', async () => {
const local = aLocalExtension('a');
const enablementService = instantiationService.get(IWorkbenchExtensionEnablementService);
await enablementService.setEnablement([local], EnablementState.DisabledGlobally);
await enablementService.setEnablement([local], EnablementState.EnabledWorkspace);

instantiationService.stubPromise(IExtensionManagementService, 'getInstalled', [local]);
instantiationService.stub(IExtensionService, {
extensions: [toExtensionDescription(local)],
onDidChangeExtensions: Event.None,
whenInstalledExtensionsRegistered: () => Promise.resolve(true)
});

return instantiationService.get(IExtensionsWorkbenchService).queryLocal()
.then(extensions => {
const testObject: ExtensionsActions.DisableGloballyAction = disposables.add(instantiationService.createInstance(ExtensionsActions.DisableGloballyAction));
testObject.extension = extensions[0];
assert.ok(!testObject.enabled);
});
});

});

suite('ExtensionRuntimeStateAction', () => {
Expand Down