Skip to content

[physx] Fix x86 Linux build errors #30014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dan-shaw merged 1 commit into from
Mar 20, 2023
Merged

[physx] Fix x86 Linux build errors #30014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ports/physx/fix-compiler-flag.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,20 @@ index a1ab3596..dbd20fb0 100644

# cache lib type defs
IF(PX_GENERATE_STATIC_LIBRARIES)
diff --git a/physx/source/compiler/cmake/linux/CMakeLists.txt b/physx/source/compiler/cmake/linux/CMakeLists.txt
index 6246e488..7bf0cc30 100644
--- a/physx/source/compiler/cmake/linux/CMakeLists.txt
+++ b/physx/source/compiler/cmake/linux/CMakeLists.txt
@@ -36,6 +36,11 @@ IF ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
SET(PHYSX_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-rtti -fno-exceptions -ffunction-sections -fdata-sections -fstrict-aliasing ${CLANG_WARNINGS}" CACHE INTERNAL "PhysX CXX")
ELSEIF ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
SET(PHYSX_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-rtti -fno-exceptions -ffunction-sections -fdata-sections -fno-strict-aliasing ${GCC_WARNINGS}" CACHE INTERNAL "PhysX CXX")
+
+ # Enable SSE2 and fix double alignment for 32-bit x86 builds
Copy link
Contributor

@dan-shaw dan-shaw Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit this fix to upstream?

Copy link
Contributor Author

@dpogue dpogue Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but upstream tends to never accept pull requests and is no longer supported by Nvidia (they have a different repo for their PhysX v5.1.x release which also doesn't really seem to accept pull requests)

+ IF (CMAKE_SYSTEM_PROCESSOR MATCHES "i686.*|i386.*|x86.*")
+ STRING(APPEND PHYSX_CXX_FLAGS " -malign-double -msse2")
+ ENDIF()
ENDIF()

# Build debug info for all configurations

2 changes: 1 addition & 1 deletion ports/physx/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "physx",
"version": "4.1.2",
"port-version": 5,
"port-version": 6,
"description": "The NVIDIA PhysX SDK is a scalable multi-platform physics solution supporting a wide range of devices, from smartphones to high-end multicore CPUs and GPUs",
"homepage": "https://github.com/NVIDIAGameWorks/PhysX",
"license": null,
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6017,7 +6017,7 @@
},
"physx": {
"baseline": "4.1.2",
"port-version": 5
"port-version": 6
},
"picojson": {
"baseline": "1.3.0",
Expand Down
5 changes: 5 additions & 0 deletions versions/p-/physx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "038801f9419a356c7082b1501620bdef60da6d66",
"version": "4.1.2",
"port-version": 6
},
{
"git-tree": "b081926dc46f3fadf1696719e4b708f4cd136f25",
"version": "4.1.2",
Expand Down